Skip to content
This repository

JUpdater does not work for components #480

Merged
merged 1 commit into from over 2 years ago

2 participants

Nicholas K. Dionysopoulos Christophe Demko
Nicholas K. Dionysopoulos

JUpdater does not work for components if their XML update element did not explicitly include a folder and client_id child node. This is undesirable, because it is always folder="" and client_id=1 for components. The workaround is to set these values as defaults in JUpdaterExtension. Plugins, modules and templates don't have a problem, as they do specify those elements when necessary.

This pull request is a follow-up to the Joomla! CMS tracker item #27023 (http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=27023) and the related discussion on the Joomla! Dev General list (https://groups.google.com/forum/#!topic/joomla-dev-general/R4g0-Q2pWXk)

Nicholas K. Dionysopoulos JUpdater does not work for components if their XML update element did…
… not explicitly include a folder and client_id child node
a87dd5f
Christophe Demko chdemko merged commit 2760aac into from
Christophe Demko chdemko closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Nov 02, 2011
Nicholas K. Dionysopoulos JUpdater does not work for components if their XML update element did…
… not explicitly include a folder and client_id child node
a87dd5f
This page is out of date. Refresh to see the latest.
3  docs/manual/appendices/changelog.xml
@@ -1137,6 +1137,9 @@ http://groups.google.com/group/joomla-dev-framework/browse_thread/thread/2bbd283
1137 1137
 )</para>
1138 1138
 				<para>The function getUserState in the JApplication class is missing the $default parameter</para>
1139 1139
 			</listitem>
  1140
+			<listitem>
  1141
+				<para>JUpdater does not work for components if their XML update element did not explicitly include a folder and client_id child node</para>
  1142
+			</listitem>
1140 1143
     </itemizedlist>
1141 1144
   </sect1>
1142 1145
 </appendix>
2  libraries/joomla/updater/adapters/extension.php
@@ -43,6 +43,8 @@ protected function _startElement($parser, $name, $attrs = array())
43 43
 				$this->current_update = JTable::getInstance('update');
44 44
 				$this->current_update->update_site_id = $this->_update_site_id;
45 45
 				$this->current_update->detailsurl = $this->_url;
  46
+				$this->current_update->folder = "";
  47
+				$this->current_update->client_id = 1;
46 48
 				break;
47 49
 			// Don't do anything
48 50
 			case 'UPDATES':
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.