Added missing references =& instead of assignments = for array of module... #540

Merged
merged 1 commit into from Nov 23, 2011

Projects

None yet

3 participants

@beat
Contributor
beat commented Nov 19, 2011

Proposing to add missing references =& instead of assignments = for array of module objects in the references chain. JModuleHelper::_load returns a reference, but it is used is by assignment, instead of by reference assignment.

@beat beat Added missing references =& instead of assignments = for array of mod…
…ule objects in the references chain. JModuleHelper::_load returns a reference, but it is used is by assignment, instead of by reference assignment.
485acbd
@joomla-jenkins
Contributor

Unit testing complete. There were 0 failures and 0 errors from 1707 tests and 10661 assertions.
Checkstyle analysis reported 235 warnings and 0 errors.

@eddieajau eddieajau merged commit 4ee090a into joomla:staging Nov 23, 2011
@eddieajau
Contributor

Thanks Beat.

@beat
Contributor
beat commented Nov 23, 2011

You are welcome, Andrew. Thank you for merging, developing and maintaining.

I discovered here that contributing small fixes to Joomla Framework on GitHub within the web-browser directly is not only way simpler than with any other patching or svn methods, but also fun and impressively working well!.

@eddieajau
Contributor

:) Github is awesome (except for the little things that really annoy me, hehe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment