Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update PHPMailer to version 5.2 #543

Merged
merged 3 commits into from Nov 24, 2011

Conversation

Projects
None yet
3 participants
Owner

mbabker commented Nov 19, 2011

Update PHPMailer library to 5.2. Added the POP3 class, removed the English language file as it is set within the code and not distributed anymore, and alphabetized the Joomla! language file.

@mbabker mbabker Update PHPMailer
Update PHPMailer library to 5.2.  Added the POP3 class, removed the English language file as it is set within the code and not distributed anymore, and alphabetized the Joomla! language file.
1b0d846

Unit testing complete. There were 0 failures and 0 errors from 1707 tests and 10661 assertions.
Checkstyle analysis reported 235 warnings and 0 errors.

Build triggered by changes to the head.

Unit testing complete. There were 0 failures and 0 errors from 1735 tests and 10781 assertions.
Checkstyle analysis reported 235 warnings and 0 errors.

@eddieajau eddieajau and 1 other commented on an outdated diff Nov 23, 2011

libraries/phpmailer/phpmailer.php
@@ -56,7 +53,7 @@ class PHPMailer {
* Sets the CharSet of the message.
* @var string
*/
- public $CharSet = 'utf-8';
+ public $CharSet = 'iso-8859-1';
@eddieajau

eddieajau Nov 23, 2011

Contributor

Does this change in charset affect us at all?

@mbabker

mbabker Nov 23, 2011

Owner

I looked at the PHPMailer 5.1 tag, and it has the ISO charset as well.
I'm thinking we might've changed it internally, so I'll go ahead and
commit that change.

On 11/23/11 12:23 PM, "Andrew Eddie"
<reply+p-247525-461c72b0f132fbf05483aed73d562b0c4bb0e472-368545@reply.githu
b.com> wrote:

@@ -56,7 +53,7 @@ class PHPMailer {
* Sets the CharSet of the message.
* @var string
*/

  • public $CharSet = 'utf-8';
  • public $CharSet = 'iso-8859-1';

Does this change in charset affect us at all?


Reply to this email directly or view it on GitHub:
https://github.com/joomla/joomla-platform/pull/543/files#r247525

Build triggered by changes to the head.

Unit testing complete. There were 0 failures and 0 errors from 1863 tests and 11075 assertions.
Checkstyle analysis reported 235 warnings and 0 errors.

@eddieajau eddieajau added a commit that referenced this pull request Nov 24, 2011

@eddieajau eddieajau Merge pull request #543 from mbabker/phpmailer
Update PHPMailer to version 5.2
30f5a23

@eddieajau eddieajau merged commit 30f5a23 into joomla:staging Nov 24, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment