Issue #27898 #805

Merged
merged 2 commits into from Feb 1, 2012

Projects

None yet

4 participants

@laoneo

Added a check if the buffer from the document is really an array. Issue
number is #27898 on joomlacode.

@laoneo

The cache class needs an array from $buffer1 = $document->getBuffer(); but when a Ajax request is done with a json response the $buffer1 is a string.

@joomla-jenkins

Unit testing complete. There were 0 failures and 0 errors from 1991 tests and 11151 assertions.
Checkstyle analysis reported 165 warnings and 2 errors.

@realityking realityking commented on an outdated diff Jan 30, 2012
libraries/joomla/cache/cache.php
@@ -549,6 +549,9 @@ public static function setWorkarounds($data, $options = array())
// Get the modules buffer before component execution.
$buffer1 = $document->getBuffer();
+ if(!is_array($buffer1)){
@realityking
realityking Jan 30, 2012

You need a space after the if and the { goes on a new line.

@realityking realityking commented on an outdated diff Jan 30, 2012
libraries/joomla/cache/cache.php
@@ -605,6 +608,9 @@ public static function setWorkarounds($data, $options = array())
// @todo Check if the following is needed, seems like it should be in page cache
// Get the module buffer after component execution.
$buffer2 = $document->getBuffer();
+ if(!is_array($buffer2)){
@joomla-jenkins

Build triggered by changes to the head.

Unit testing complete. There were 0 failures and 0 errors from 1991 tests and 11151 assertions.
Checkstyle analysis reported 165 warnings and 0 errors.

@LouisLandry

Thanks a bunch!

@LouisLandry LouisLandry merged commit 5475de4 into joomla:staging Feb 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment