This repository has been archived by the owner. It is now read-only.

Redirect workarounds #94

Merged
merged 4 commits into from Jul 15, 2011

Conversation

Projects
None yet
4 participants
Contributor

rvsjoen commented Jul 11, 2011

Remove old workaround for webkit browsers, and make the workaround for msie more targeted. Older webkit browsers will still work, but take a performance hit, however I think it is more important to get rid of workarounds.

https://groups.google.com/forum/#!topic/joomla-dev-framework/8DPWgYnsSQs

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=26335

Contributor

realityking commented Jul 11, 2011

Older Webkit browsers is an euphemism. The issue in Webkit was only closed in march this year. That means current Safari and current Safari on iOS are effected. Not to mention all the smaller webkit browsers used in handheld devices. (Chrome 11 is most likely also still affected)

As much as the workaround sucks, I don't think we can get rid of it just yet. Maybe for 1.8.

The IE fix looks good.

Contributor

GeraintEdwards commented Jul 11, 2011

mbstring is not a standard php extension see http://www.php.net/manual/en/mbstring.installation.php - I did a look but could not see if this was a requirement of Joomla 1.7?

There are ideas here http://stackoverflow.com/questions/1473441/php-checks-to-see-if-a-string-is-utf8-encoded-how that don't require mbstring

Contributor

rvsjoen commented Jul 13, 2011

Ok, what about using the phputf8 library for this, see updated diff

That looks good to me (assuming the phputf8 test works of course).

LouisLandry added a commit that referenced this pull request Jul 15, 2011

@LouisLandry LouisLandry merged commit 18bfea5 into joomla:master Jul 15, 2011

LouisLandry added a commit that referenced this pull request Jul 23, 2011

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.