Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

Improve Varnish config #85

Closed
6 tasks done
stevenrombauts opened this issue Aug 29, 2016 · 0 comments
Closed
6 tasks done

Improve Varnish config #85

stevenrombauts opened this issue Aug 29, 2016 · 0 comments
Assignees
@stevenrombauts
Milestone
v1.5.0

Comments

@stevenrombauts
Copy link
Member

stevenrombauts commented Aug 29, 2016 •
edited
Loading

The VCL should be made smarter:

  • Move Varnish to port 8080 and Apache back to 80.
  • Make sure Varnish does not modify anything in the response or request when it's disabled, and
  • never replace the Cache-Control: no-cache header (code). Only if Varnish cache is effectively enabled. (Related to Do not modify headers in backend response #52) Note: also not if a user is logged in, but we don't have any logic for this because Joomla always sets a session cookie.
  • Don't remove etags in vcl_backend_response
  • Don't pass ajax requests by default
  • Ignore GET requests to /varnish-enabled in the access logs, or move them to a different log.
@stevenrombauts stevenrombauts added this to the v1.5.0 milestone Aug 29, 2016
@stevenrombauts stevenrombauts changed the title Do not override no-cache header Improve the VCL Aug 29, 2016
stevenrombauts pushed a commit that referenced this issue Aug 29, 2016
#85: Do not modify headers when Varnish is disabled
4fdad06 
Although we simply return(pass) in vcl_fetch() when
we disabled Varnish, headers are still being modified
in vcl_backend_response(). We should return(deliver)
if Varnish disabled.
stevenrombauts pushed a commit that referenced this issue Aug 29, 2016
#85: Do not set beresp.ttl to 0 when skipping vcl_backend_response
bc16042 
If you skip the built-in subroutine and set 0 as TTL value, you are
effectively removing objects from cache that could eventually be used to avoid request serialization.
See: http://book.varnish-software.com/4.0/chapters/VCL_Basics.html\#vcl-backend-response
@stevenrombauts stevenrombauts self-assigned this Aug 29, 2016
stevenrombauts pushed a commit that referenced this issue Oct 16, 2017
#85: Do not modify headers when Varnish is disabled
c55de11 
Although we simply return(pass) in vcl_fetch() when
we disabled Varnish, headers are still being modified
in vcl_backend_response(). We should return(deliver)
if Varnish disabled.
stevenrombauts pushed a commit that referenced this issue Oct 28, 2017
#85: Don't remove etags in vcl_backend_response
c3ee7e6
stevenrombauts pushed a commit that referenced this issue Oct 28, 2017
#85: Don't pass ajax requests by default
6ef11ff
stevenrombauts pushed a commit that referenced this issue Oct 28, 2017
#85: Don't log requests to /varnish-enabled
b2f3ef7
stevenrombauts pushed a commit that referenced this issue Oct 28, 2017
#85: Move Apache back to port 80
b9e3323
stevenrombauts pushed a commit that referenced this issue Oct 28, 2017
#85: Fix tests
fe66396
@stevenrombauts stevenrombauts mentioned this issue Oct 28, 2017
Merged
@stevenrombauts stevenrombauts mentioned this issue Oct 28, 2017
Closed
@stevenrombauts stevenrombauts changed the title Improve the VCL Improve Varnish config Nov 5, 2017
@stevenrombauts stevenrombauts mentioned this issue Nov 17, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stevenrombauts stevenrombauts

Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
1 participant
@stevenrombauts