Read message value directly from options #141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
With the changes in PR #139, specifying a symbolized value for the
message
option would cause that method to be called on the Modelobject. If that method didn't exist, it resulted in a
NoMethodError
exception. If that method did exist in the Model, and also as an i18n
key, then the Model method was used, as opposed to the i18n key.
The
message
option is meant to either be a String, or a symbolcorresponding to an i18n key. Therefore, it should be read directly
from
options[:message]
and not sent for further processing by theoptions_value
method.How:
error_message
method back to its value prior to PR Adds ability to pass symbols as option values to phony model helpers #139,so that it uses
options[:message]
Closes #140.