From f154e031cc92f6934cd49b5c9be3d4323cf77c2c Mon Sep 17 00:00:00 2001 From: scarf Date: Mon, 25 Apr 2022 13:53:48 +0900 Subject: [PATCH 1/3] fix: Fix error on jupyter notebook (#40) replaces Diagraph's _repr_svg() method (deprecated) into _repr_image_svg_xml() fixes #40 --- binarytree/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/binarytree/__init__.py b/binarytree/__init__.py index f8e0f1a..21a74f0 100644 --- a/binarytree/__init__.py +++ b/binarytree/__init__.py @@ -509,7 +509,7 @@ def _repr_svg_(self) -> str: # pragma: no cover """ try: # noinspection PyProtectedMember - return str(self.graphviz()._repr_svg_()) + return self.graphviz()._repr_image_svg_xml() except (SubprocessError, ExecutableNotFound, FileNotFoundError): return self.svg() From d11352272de0e9c155cdaa16c10cc3b53d25c8d8 Mon Sep 17 00:00:00 2001 From: scarf Date: Wed, 27 Apr 2022 07:04:49 +0900 Subject: [PATCH 2/3] fix: Add backward compatibility --- binarytree/__init__.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/binarytree/__init__.py b/binarytree/__init__.py index 21a74f0..93ba05c 100644 --- a/binarytree/__init__.py +++ b/binarytree/__init__.py @@ -508,8 +508,12 @@ def _repr_svg_(self) -> str: # pragma: no cover .. _Jupyter notebooks: https://jupyter.org """ try: - # noinspection PyProtectedMember - return self.graphviz()._repr_image_svg_xml() + try: + # noinspection PyProtectedMember + return str(self.graphviz()._repr_svg_()) + except AttributeError: + # noinspection PyProtectedMember + return self.graphviz()._repr_image_svg_xml() except (SubprocessError, ExecutableNotFound, FileNotFoundError): return self.svg() From f8978f0c552c23ace441ba0b0cfeb72232ba4bb3 Mon Sep 17 00:00:00 2001 From: scarf Date: Wed, 27 Apr 2022 07:08:59 +0900 Subject: [PATCH 3/3] Style: remove tabs --- binarytree/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/binarytree/__init__.py b/binarytree/__init__.py index 93ba05c..af3566b 100644 --- a/binarytree/__init__.py +++ b/binarytree/__init__.py @@ -513,7 +513,7 @@ def _repr_svg_(self) -> str: # pragma: no cover return str(self.graphviz()._repr_svg_()) except AttributeError: # noinspection PyProtectedMember - return self.graphviz()._repr_image_svg_xml() + return self.graphviz()._repr_image_svg_xml() except (SubprocessError, ExecutableNotFound, FileNotFoundError): return self.svg()