Support creating templates only using tags #11
Conversation
|
Is this PR still a draft? My templates aren't migrated in to the new system. Also, the popup dialogue says that there is a help option under Templates, but it doesn't seem to exist yet. |
I'll create another PR for this.
That will also be done in a separate PR. But wrote this so, I don't have to change it in future. |
|
I haven't merged this yet so that we can wait for the conclusion of #12. |
… notebook" This reverts commit 5396a4a.
nishantwrp
changed the title
|
@CalebJohn please take a look. I'll add the feature to load previous templates in a separate PR. So, this can be merged. |
| }; | ||
|
|
||
| export const getAllNotesInFolder = async (folderId: string): Promise<Note[]> => { | ||
| let pageNum = 1; |
There was a problem hiding this comment.
Is this function (and module) needed anymore?
There was a problem hiding this comment.
No, they're not thanks for pointing that out. If this is the only review comment, you can merge this pr, I'll remove these functions in the next pr.
There was a problem hiding this comment.
Good to see that we're on the same page. I'm looking forward to the next PR.
|
I just have the one comment, I don't think that function is needed anymore, but it's something you can address later, I'll merge this now. It looks good! |
This PR does two things.
Fixes #10, Fixes #12.