Parser: Handlebars integration #3
Conversation
| @@ -1,3 +1,29 @@ | |||
| export const parseTemplate = async (template: string): Promise<string> => { | |||
| return template; | |||
There was a problem hiding this comment.
I'm going to miss the old parser. Simple, but it works.
| "handlebars": "^4.7.7", | ||
| "html-entities": "^2.3.2", | ||
| "moment": "^2.29.1", |
There was a problem hiding this comment.
By the way is there a reason why all the dependencies are under devDependencies? Doesn't it mean that the libs won't be packaged with the plugin when you publish?
There was a problem hiding this comment.
Won't webpack automatically include it in the bundled js?
There was a problem hiding this comment.
I don't know what webpack does, but devDependencies as the name says is for development - so for example the TypeScript package, eslint, etc. However packages you actually used in the plugin such as handlebars or moment should be under the "dependencies" key.
There was a problem hiding this comment.
Oh ok, I'll create a PR for correcting this.
parserusing handlebars.