Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser: Handlebars integration #3

Merged
merged 3 commits into from
Jul 11, 2021
Merged

Parser: Handlebars integration #3

merged 3 commits into from
Jul 11, 2021

Conversation

nishantwrp
Copy link
Collaborator

  • Implement parser using handlebars.
  • Made sure all the current templates are compatible with this plugin.

@@ -1,3 +1,29 @@
export const parseTemplate = async (template: string): Promise<string> => {
return template;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to miss the old parser. Simple, but it works.

@CalebJohn CalebJohn merged commit bab052c into master Jul 11, 2021
Comment on lines +23 to +25
"handlebars": "^4.7.7",
"html-entities": "^2.3.2",
"moment": "^2.29.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way is there a reason why all the dependencies are under devDependencies? Doesn't it mean that the libs won't be packaged with the plugin when you publish?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't webpack automatically include it in the bundled js?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what webpack does, but devDependencies as the name says is for development - so for example the TypeScript package, eslint, etc. However packages you actually used in the plugin such as handlebars or moment should be under the "dependencies" key.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok, I'll create a PR for correcting this.

@nishantwrp nishantwrp deleted the handlebars branch July 11, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants