New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSGi support #65

Closed
aborg0 opened this Issue Sep 13, 2014 · 12 comments

Comments

Projects
None yet
3 participants
@aborg0

aborg0 commented Sep 13, 2014

It would be nice to be able to use jopt-simple from OSGi environments. As it has no compile dependencies, it would mean that a symbolic name, version and the exported packages need to be added to the MANIFEST.MF file.

@pholser

This comment has been minimized.

Show comment
Hide comment
@pholser

pholser Sep 13, 2014

Collaborator

@aborg0 Thanks for your interest! Will you have a look at the pull req I've issued regarding this? I want to make sure that the build (using maven-bundle-plugin) will produce a JAR file with the OSGi metadata you're looking for.

Collaborator

pholser commented Sep 13, 2014

@aborg0 Thanks for your interest! Will you have a look at the pull req I've issued regarding this? I want to make sure that the build (using maven-bundle-plugin) will produce a JAR file with the OSGi metadata you're looking for.

pholser added a commit that referenced this issue Sep 13, 2014

Merge pull request #66 from pholser/feature/osgi-support
For #65, use maven-bundle-plugin to build JAR as OSGi bundle
@pholser

This comment has been minimized.

Show comment
Hide comment
@pholser

pholser Sep 13, 2014

Collaborator

Latest 4.8 snapshot at oss.sonatype.org should have this change.

Collaborator

pholser commented Sep 13, 2014

Latest 4.8 snapshot at oss.sonatype.org should have this change.

@pholser pholser closed this Sep 13, 2014

@boly38

This comment has been minimized.

Show comment
Hide comment
@boly38

boly38 Oct 7, 2014

@pholser thanks for your feedback; 4.8 snapshot from oss sonatype is usefull for me!

I know this is so so minor, but while adding OSGi directives in MANIFEST.MF
could you finalize this by adding the following

 Bundle-Vendor

(One of my components parse each bundle to get name and vendor attributes)
regards

boly38 commented Oct 7, 2014

@pholser thanks for your feedback; 4.8 snapshot from oss sonatype is usefull for me!

I know this is so so minor, but while adding OSGi directives in MANIFEST.MF
could you finalize this by adding the following

 Bundle-Vendor

(One of my components parse each bundle to get name and vendor attributes)
regards

@pholser

This comment has been minimized.

Show comment
Hide comment
@pholser

pholser Oct 7, 2014

Collaborator

@boly38 Sure thing. Will probably use "JOpt Simple" as the value.

Collaborator

pholser commented Oct 7, 2014

@boly38 Sure thing. Will probably use "JOpt Simple" as the value.

@pholser pholser reopened this Oct 7, 2014

@boly38

This comment has been minimized.

Show comment
Hide comment
@boly38

boly38 commented Oct 7, 2014

^^

@pholser

This comment has been minimized.

Show comment
Hide comment
@pholser

pholser Oct 7, 2014

Collaborator

@boly38 Latest 4.8 snapshot at oss.sonatype.org should have the Bundle-Vendor set.

Collaborator

pholser commented Oct 7, 2014

@boly38 Latest 4.8 snapshot at oss.sonatype.org should have the Bundle-Vendor set.

@boly38

This comment has been minimized.

Show comment
Hide comment
@boly38

boly38 Oct 7, 2014

excellent. thanks

boly38 commented Oct 7, 2014

excellent. thanks

@pholser pholser closed this Oct 7, 2014

@aborg0

This comment has been minimized.

Show comment
Hide comment
@aborg0

aborg0 Oct 15, 2014

@pholser do you have an estimate for the next release date? It would be nice to use jopt-simple as a released OSGi dependency. (We will reach the feature freeze next week, but if the jopt-simple will be released soon, we would make an exception.)
Thanks.

aborg0 commented Oct 15, 2014

@pholser do you have an estimate for the next release date? It would be nice to use jopt-simple as a released OSGi dependency. (We will reach the feature freeze next week, but if the jopt-simple will be released soon, we would make an exception.)
Thanks.

@pholser

This comment has been minimized.

Show comment
Hide comment
@pholser

pholser Oct 15, 2014

Collaborator

@aborg0 Releases of JOpt Simple are somewhat irregular. I tend to wait until a significant number of features has accumulated before declaring a new point release. It seems that the differences between 4.7 and what would be 4.8 are the OSGi metadata and i18n of exception messaging.

I think perhaps I will declare 4.8 beta 1, and let these changes be vetted. Sound good? If things look pretty good after a week or two with 4.8 beta 1 in the wild, I'll declare 4.8.

Collaborator

pholser commented Oct 15, 2014

@aborg0 Releases of JOpt Simple are somewhat irregular. I tend to wait until a significant number of features has accumulated before declaring a new point release. It seems that the differences between 4.7 and what would be 4.8 are the OSGi metadata and i18n of exception messaging.

I think perhaps I will declare 4.8 beta 1, and let these changes be vetted. Sound good? If things look pretty good after a week or two with 4.8 beta 1 in the wild, I'll declare 4.8.

@aborg0

This comment has been minimized.

Show comment
Hide comment
@aborg0

aborg0 Oct 15, 2014

@pholser Thanks, that sounds good.

aborg0 commented Oct 15, 2014

@pholser Thanks, that sounds good.

@pholser

This comment has been minimized.

Show comment
Hide comment
@pholser

pholser Oct 15, 2014

Collaborator

@aborg0 @boly38 4.8 beta 1 should be available on GitHub right now; in Maven central as soon as Sonatype syncs it.

Collaborator

pholser commented Oct 15, 2014

@aborg0 @boly38 4.8 beta 1 should be available on GitHub right now; in Maven central as soon as Sonatype syncs it.

boly38 added a commit to boly38/json-schema-validator-bundle that referenced this issue Oct 16, 2014

Update jopt-simple to release version
Update jopt-simple from (4.8-SNAPSHOT) to release (4.8-beta-1) version
cf. jopt-simple/jopt-simple#65 (comment)
special thanks @pholser
@aborg0

This comment has been minimized.

Show comment
Hide comment
@aborg0

aborg0 Oct 21, 2014

@pholser Thanks, it seems to be perfect from my point of view.
(I have included it in my (osgi source bundles project)[https://github.com/aborg0/osgi_source_bundles], so that way it is easier to use from an OSGi environment, like eclipse. If you prefer, you can add a separate module for the OSGi sources. The howto is here: http://codeiseasy.wordpress.com/2012/07/22/convert-a-maven-source-bundle-to-an-eclipse-source-bundle/ not sure how well it works for Sonatype/maven central releases.)

aborg0 commented Oct 21, 2014

@pholser Thanks, it seems to be perfect from my point of view.
(I have included it in my (osgi source bundles project)[https://github.com/aborg0/osgi_source_bundles], so that way it is easier to use from an OSGi environment, like eclipse. If you prefer, you can add a separate module for the OSGi sources. The howto is here: http://codeiseasy.wordpress.com/2012/07/22/convert-a-maven-source-bundle-to-an-eclipse-source-bundle/ not sure how well it works for Sonatype/maven central releases.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment