New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide localization support for BuiltinHelpFormatter #72

Closed
domgold opened this Issue Jan 14, 2015 · 8 comments

Comments

Projects
None yet
2 participants
@domgold

domgold commented Jan 14, 2015

It would be nice to have localization support for the BuiltinHelpFormatter, like you did for the exception messages.

Currently the only way I found to localize BuiltinHelpFormatter is to provide my own implementation, copying all the code in my own class.

@pholser

This comment has been minimized.

Show comment
Hide comment
@pholser

pholser Jan 14, 2015

Collaborator

Agreed, a good idea.

Collaborator

pholser commented Jan 14, 2015

Agreed, a good idea.

@pholser

This comment has been minimized.

Show comment
Hide comment
@pholser

pholser Jan 14, 2015

Collaborator

See also #68.

Collaborator

pholser commented Jan 14, 2015

See also #68.

@pholser

This comment has been minimized.

Show comment
Hide comment
@pholser

pholser Feb 1, 2015

Collaborator

@domgold Branch feature/72/localization-of-help-formatter has some work on this. Have a look and see whether this suits your needs -- if there's anything else you'd like to be localizable, or things that I've factored into bundles that don't need to be.

Also, translations are more than welcome for inclusion in the project.

Thanks!

Collaborator

pholser commented Feb 1, 2015

@domgold Branch feature/72/localization-of-help-formatter has some work on this. Have a look and see whether this suits your needs -- if there's anything else you'd like to be localizable, or things that I've factored into bundles that don't need to be.

Also, translations are more than welcome for inclusion in the project.

Thanks!

@domgold

This comment has been minimized.

Show comment
Hide comment
@domgold

domgold Feb 3, 2015

That's exactly what we need! Do think you can release to central in the near future?
I could provide French and German translation at the end of our project, once the translation has been validated by the product owner.

domgold commented Feb 3, 2015

That's exactly what we need! Do think you can release to central in the near future?
I could provide French and German translation at the end of our project, once the translation has been validated by the product owner.

@pholser

This comment has been minimized.

Show comment
Hide comment
@pholser

pholser Feb 3, 2015

Collaborator

@domgold Great, I'll merge this in. I anticipate cutting a 4.9 beta release this week.

Collaborator

pholser commented Feb 3, 2015

@domgold Great, I'll merge this in. I anticipate cutting a 4.9 beta release this week.

@pholser

This comment has been minimized.

Show comment
Hide comment
@pholser

pholser Feb 3, 2015

Collaborator

@domgold oss.sonatype.org should have the latest 4.9 snapshot with these changes.

Collaborator

pholser commented Feb 3, 2015

@domgold oss.sonatype.org should have the latest 4.9 snapshot with these changes.

@pholser

This comment has been minimized.

Show comment
Hide comment
@pholser

pholser Feb 9, 2015

Collaborator

@domgold 4.9 beta 1 is at Maven central.

Collaborator

pholser commented Feb 9, 2015

@domgold 4.9 beta 1 is at Maven central.

@domgold

This comment has been minimized.

Show comment
Hide comment
@domgold

domgold Feb 15, 2015

Thanks for notifying. I'll give it a try next week.

domgold commented Feb 15, 2015

Thanks for notifying. I'll give it a try next week.

@pholser pholser closed this Sep 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment