Fixed some unpleasances with SimpleDateFormat and added convenience methods #3

Merged
merged 4 commits into from Jun 29, 2011

Conversation

Projects
None yet
2 participants
@michael-o
Contributor

michael-o commented Jun 29, 2011

Hi Paul,

just started using your lib in my second app and fixed some bugs and missing features:

  1. The JDK has some bugs in the localized patterns, see log messages. So I reverted to generic patterns
  2. I badly needed to check for the absence of opts and non-opt arguments
@pholser

This comment has been minimized.

Show comment
Hide comment
@pholser

pholser Jun 29, 2011

Collaborator

Thanks! Wasn't aware of all the problems with localized date/time patterns.

I'm inclined to leave out OptionSet.hasNonOptionArguments() -- not sure that it communicates that much more clearly than OptionSet.nonOptionArguments().isEmpty(). I'll definitely roll in the other changes.

Collaborator

pholser commented Jun 29, 2011

Thanks! Wasn't aware of all the problems with localized date/time patterns.

I'm inclined to leave out OptionSet.hasNonOptionArguments() -- not sure that it communicates that much more clearly than OptionSet.nonOptionArguments().isEmpty(). I'll definitely roll in the other changes.

@michael-o

This comment has been minimized.

Show comment
Hide comment
@michael-o

michael-o Jun 29, 2011

Contributor

That's great. Thanks for the quick response.

Contributor

michael-o commented Jun 29, 2011

That's great. Thanks for the quick response.

pholser added a commit that referenced this pull request Jun 29, 2011

Merge pull request #3 from michael-o/master
Fixed some unpleasances with SimpleDateFormat and added convenience methods

@pholser pholser merged commit ebd2223 into jopt-simple:master Jun 29, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment