Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destructive button style for the action sheet #3

Merged
merged 2 commits into from Jul 11, 2020
Merged

Add destructive button style for the action sheet #3

merged 2 commits into from Jul 11, 2020

Conversation

majouji
Copy link
Collaborator

@majouji majouji commented Jul 11, 2020

  • Add the .destructive button style for the action sheet component
  • Add a second default button to further emphasize that the action sheet is meant to be used to present explicit options for the user to choose from (instead of the "OK"/"Done" dismissal which is usually better suited for an alert)
  • Add *.DS_Store to gitignore cuz it’s annoying

Per the HIG, the destructive style is the first option presented (reference).

- Add destructive button style in action sheet
- Add another default button to better show the ideal use of the action sheet (per the HIG)
@jordansinger
Copy link
Owner

great addition!

@jordansinger jordansinger merged commit b8b65b3 into jordansinger:master Jul 11, 2020
@majouji majouji deleted the add-destructive-button-style branch July 11, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants