New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deb] support activate-noawait and interest-noawait #1225

Closed
philtay opened this Issue Nov 9, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@philtay

philtay commented Nov 9, 2016

Currently --deb-activate and --deb-interest options allow to specify activate and interest triggers only. Please add --deb-activate-noawait and --deb-interest-noawait options to support activate-noawait and interest-noawait triggers too. More info on deb-triggers here. It looks like a trivial PR, but I don't speak Ruby.

@nthykier

This comment has been minimized.

nthykier commented Apr 3, 2017

Very much a good idea. The average user of triggers generally want the "-noawait" variant and notably it avoids the entire problem of "trigger-cycles". I would go so far to as to recommend people to use the noawait triggers by default in the documentation.

@philtay

This comment has been minimized.

philtay commented Apr 4, 2017

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Apr 4, 2017

@ppoilbarbe

This comment has been minimized.

Contributor

ppoilbarbe commented Jun 19, 2017

I have done it... It's not quite difficult even if I do not understand all the magic under the hood of Ruby (I did just mimic what have been done for --deb-interest and --deb-activate).
Do you prefer a patch or a merge request ?
Edit: Added a merge request (#1359)

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jul 20, 2017

#1359 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment