New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-files behaving strangely in 1.9.1 #1390

Closed
jordansissel opened this Issue Jul 29, 2017 · 3 comments

Comments

Projects
None yet
1 participant
@jordansissel
Owner

jordansissel commented Jul 29, 2017

A lesson: Passing tests doesn't mean nothing is broken ;)

Here's a scenario where fpm's --config-files setting fails now in fpm 1.9.1

/usr/lib/ruby/2.3.0/fileutils.rb:1387:in `copy': unknown file type: /etc/packetbeat/packetbeat.yml (RuntimeError)
	from /usr/lib/ruby/2.3.0/fileutils.rb:472:in `block in copy_entry'
	from /usr/lib/ruby/2.3.0/fileutils.rb:1498:in `wrap_traverse'
	from /usr/lib/ruby/2.3.0/fileutils.rb:469:in `copy_entry'
	from /usr/lib/ruby/2.3.0/fileutils.rb:444:in `block in cp_r'
	from /usr/lib/ruby/2.3.0/fileutils.rb:1571:in `block in fu_each_src_dest'
	from /usr/lib/ruby/2.3.0/fileutils.rb:1587:in `fu_each_src_dest0'
	from /usr/lib/ruby/2.3.0/fileutils.rb:1569:in `fu_each_src_dest'
	from /usr/lib/ruby/2.3.0/fileutils.rb:443:in `cp_r'
	from /var/lib/gems/2.3.0/gems/fpm-1.9.1/lib/fpm/package/rpm.rb:480:in `block in output'
	from /var/lib/gems/2.3.0/gems/fpm-1.9.1/lib/fpm/package/rpm.rb:476:in `each'
	from /var/lib/gems/2.3.0/gems/fpm-1.9.1/lib/fpm/package/rpm.rb:476:in `output'
	from /var/lib/gems/2.3.0/gems/fpm-1.9.1/lib/fpm/command.rb:487:in `execute'
	from /var/lib/gems/2.3.0/gems/clamp-1.0.1/lib/clamp/command.rb:68:in `run'
	from /var/lib/gems/2.3.0/gems/fpm-1.9.1/lib/fpm/command.rb:574:in `run'
	from /var/lib/gems/2.3.0/gems/clamp-1.0.1/lib/clamp/command.rb:133:in `run'
	from /var/lib/gems/2.3.0/gems/fpm-1.9.1/bin/fpm:8:in `<top (required)>'
	from /usr/local/bin/fpm:23:in `load'
	from /usr/local/bin/fpm:23:in `<main>'
@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jul 29, 2017

Minimal reproduce case:

% bin/fpm -f -s empty -t rpm --config-files /etc/foo/bar -n example
@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jul 29, 2017

Looks like 783b06f causes this. It assume config files are always external to the package source.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jul 29, 2017

fpm 1.9.2 released which hopefully fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment