New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"implicit *" behavior went away in 0.4.x #187

Closed
astrostl opened this Issue Mar 26, 2012 · 7 comments

Comments

Projects
None yet
2 participants
@astrostl

astrostl commented Mar 26, 2012

cd /tmp
mkdir -p foo/etc
mkdir -p foo/usr/bin
echo > foo/etc/foo.conf
echo > foo/usr/bin/foo
fpm -s dir -t rpm -n foo -v 1.0 -C /tmp/foo

0.3.10: "Created /tmp/foo-1.0.x86_64.rpm"

0.4.3: "You need to pass additional command arguments so that I know what you want to build packages from."

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Mar 30, 2012

Will confirm and fix this. Thanks for reporting!

@astrostl

This comment has been minimized.

astrostl commented Mar 30, 2012

I can see a very valid argument for insisting that includes be explicit. But perhaps others, like me, were scripting some stuff that relied on the former behavior.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Mar 30, 2012

So here's what I can do: If the 'source' is "dir" and you specify -C, it will imply that "." is the thing you want to input. The old behavior of:

fpm -s dir -t rpm -n foo -v 1.0 -C /tmp/foo should be the same as fpm -s dir -t rpm -n foo -v 1.0 -C /tmp/foo .

Note the '.' at the end.

I'll see about making this work.

@astrostl

This comment has been minimized.

astrostl commented Mar 30, 2012

Sounds good.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Mar 30, 2012

Here's what works for me now:


% ls /tmp/a
hello

% ruby bin/fpm -s dir -t rpm -n hello -C /tmp/a
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.U1TS3b
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.dThG0R
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.EO1YXx
Processing files: hello-1.0-1.x86_64
Wrote: /tmp/package-rpm-build20120330-21999-wn4d41/RPMS/x86_64/hello-1.0-1.x86_64.rpm
Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.OwteYT
Created rpm {"path":"hello-1.0-1.x86_64.rpm"}

% rpm -qlp hello-1.0-1.x86_64.rpm              
/hello
@astrostl

This comment has been minimized.

astrostl commented Mar 30, 2012

Looks good!

jordansissel added a commit that referenced this issue Mar 30, 2012

- If no args are given, assume '.' was intended if the source is 'dir'
  and chdir (-C) is set. Fixes issue #187
- Abort if there's no package name known.
@jordansissel

This comment has been minimized.

Owner

jordansissel commented Mar 30, 2012

This fix will appear in the next release of fpm, hopefully today :)

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 18, 2014

jls
- If no args are given, assume '.' was intended if the source is 'dir'
  and chdir (-C) is set. Fixes issue jordansissel#187
- Abort if there's no package name known.

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 27, 2014

- If no args are given, assume '.' was intended if the source is 'dir'
  and chdir (-C) is set. Fixes issue jordansissel#187
- Abort if there's no package name known.

jordansissel added a commit that referenced this issue Apr 24, 2015

- If no args are given, assume '.' was intended if the source is 'dir'
  and chdir (-C) is set. Fixes issue #187
- Abort if there's no package name known.

jordansissel added a commit that referenced this issue Jun 20, 2016

- If no args are given, assume '.' was intended if the source is 'dir'
  and chdir (-C) is set. Fixes issue #187
- Abort if there's no package name known.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment