New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests package breaks python->rpm #252

Closed
tabletcorry opened this Issue Aug 24, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@tabletcorry
Contributor

tabletcorry commented Aug 24, 2012

The requests package has a multi-line license in the package json, which appears to break fpm.

Specifically, it inserts the whole license into the spec file without escapes, so the additional lines of the license are interpreted by rpmbuild.

-e serves as an easy workaround, by deleting the extra lines.

jordansissel added a commit that referenced this issue Aug 24, 2012

jordansissel added a commit that referenced this issue Aug 24, 2012

- note fix for #252
- add regression test for #252
@jordansissel

This comment has been minimized.

Owner

jordansissel commented Aug 24, 2012

fpm 0.4.14 released with a fix. I tested with 'requests' and verified that it works.

carrera(~/projects/fpm) % rpm -qp python-requests-0.13.8-1.noarch.rpm -i
Name        : python-requests              Relocations: / 
Version     : 0.13.8                            Vendor: none
Release     : 1                             Build Date: Fri 24 Aug 2012 05:01:03 PM EDT
Install Date: (not installed)               Build Host: carrera.databits.net
Group       : default                       Source RPM: python-requests-0.13.8-1.src.rpm
Size        : 3064529                          License: Copyright (c) 2012 Kenneth Reitz.  Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted, provided that the above copyright notice and this permission notice appear in all copies.  THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
Signature   : (none)
Packager    : <jls@carrera.databits.net>
URL         : http://python-requests.org
Summary     : Python HTTP for Humans.
Description :
Python HTTP for Humans.

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 18, 2014

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 27, 2014

jordansissel added a commit that referenced this issue Apr 24, 2015

- note fix for #252
- add regression test for #252

jordansissel added a commit that referenced this issue Jun 20, 2016

- note fix for #252
- add regression test for #252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment