New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing tag causing rpm-build to fail when building gem #276

Closed
realpdm opened this Issue Oct 17, 2012 · 1 comment

Comments

Projects
None yet
3 participants
@realpdm

realpdm commented Oct 17, 2012

When trying to build the fastthread gem, rpm-build complains of an Empty tag: URL

fpm --verbose -s gem -t rpm --gem-package-name-prefix ha-rubygem --gem-gem /usr/local/bin/gem fastthread
Trying to download {"gem":"fastthread","version":null,"level":"info"}
Using gem file {"path":"/home/pmoore/fpm/vendor/ruby/1.9.1/cache/fastthread-1.0.7.gem","level":"info"}
Building native extensions. This could take a while...
Successfully installed fastthread-1.0.7
1 gem installed
Setting from flags: epoch= {"level":"info"}
Setting from flags: iteration= {"level":"info"}
Converting gem to rpm {"level":"info"}
Reading template {"path":"/home/pmoore/fpm/vendor/ruby/1.9.1/gems/fpm-0.4.20/lib/fpm/../../templates/rpm.erb","level":"info"}
Running rpmbuild {"args":["rpmbuild","-bb","--define","buildroot /tmp/package-rpm-build20121017-28813-1ina8pm/BUILD","--define","_topdir /tmp/package-rpm-build20121017-28813-1ina8pm","--define","_sourcedir /tmp/package-rpm-build20121017-28813-1ina8pm","--define","_rpmdir /tmp/package-rpm-build20121017-28813-1ina8pm/RPMS","/tmp/package-rpm-build20121017-28813-1ina8pm/SPECS/ha-rubygem-fastthread.spec"],"level":"info"}
error: line 39: Empty tag: URL:
/home/pmoore/fpm/vendor/ruby/1.9.1/gems/fpm-0.4.20/lib/fpm/util.rb:33:in safesystem': rpmbuild failed (exit code 1). Full command was:["rpmbuild", "-bb", "--define", "buildroot /tmp/package-rpm-build20121017-28813-1ina8pm/BUILD", "--define", "_topdir /tmp/package-rpm-build20121017-28813-1ina8pm", "--define", "_sourcedir /tmp/package-rpm-build20121017-28813-1ina8pm", "--define", "_rpmdir /tmp/package-rpm-build20121017-28813-1ina8pm/RPMS", "/tmp/package-rpm-build20121017-28813-1ina8pm/SPECS/ha-rubygem-fastthread.spec"] (FPM::Util::ProcessFailed) from /home/pmoore/fpm/vendor/ruby/1.9.1/gems/fpm-0.4.20/lib/fpm/package/rpm.rb:198:inoutput'
from /home/pmoore/fpm/vendor/ruby/1.9.1/gems/fpm-0.4.20/lib/fpm/command.rb:377:in execute' from /home/pmoore/fpm/vendor/ruby/1.9.1/gems/clamp-0.3.1/lib/clamp/command.rb:64:inrun'
from /home/pmoore/fpm/vendor/ruby/1.9.1/gems/clamp-0.3.1/lib/clamp/command.rb:126:in run' from /home/pmoore/fpm/vendor/ruby/1.9.1/gems/fpm-0.4.20/bin/fpm:8:in<top (required)>'
from bin/fpm:16:in load' from bin/fpm:16:in

'

@r4um

This comment has been minimized.

Contributor

r4um commented Nov 27, 2012

Looks like homepage for this gem is empty "" and therefore the URL tag.

$ gem specification -r fastthread | grep ^homepage
homepage: ""

Should URL tag be skipped (in rpm.erb) or defaulted to http://rubygems.org/gems/GEMNAME in case the homepage is "" ?

jordansissel added a commit that referenced this issue Nov 27, 2012

Merge pull request #296 from r4um/fix_276
Fix #276 Don't add empty URL

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 18, 2014

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 18, 2014

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 27, 2014

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 27, 2014

r4um added a commit that referenced this issue Apr 24, 2015

jordansissel added a commit that referenced this issue Apr 24, 2015

jordansissel pushed a commit that referenced this issue Jun 20, 2016

jordansissel added a commit that referenced this issue Jun 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment