New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--inputs foo still requires extra paramters #278

Closed
fetep opened this Issue Oct 18, 2012 · 1 comment

Comments

Projects
None yet
3 participants
@fetep
Contributor

fetep commented Oct 18, 2012

If specifying a plist with --inputs, any extra paramters should be optional (or an error?).

% fpm -s dir -t rpm -n rvm-base --inputs rvm-base.plist
/usr/lib/ruby/gems/1.8/gems/fpm-0.4.20/lib/fpm/package/deb.rb:23: warning: already initialized constant COMPRESSION_TYPES
No parameters given. You need to pass additional command arguments so that I know what you want to build packages from. For example, for '-s dir' you would pass a list of files and directories. For '-s gem' you would pass a one or more gems to package from. As a full example, this will make an rpm of the 'json' rubygem: fpm -s gem -t rpm json {"level":"warn"}

@r4um

This comment has been minimized.

Contributor

r4um commented Nov 27, 2012

👍 for making additional args optional.

jordansissel added a commit that referenced this issue Nov 27, 2012

Merge pull request #297 from r4um/fix_278
Fix #278 Don't require additional args when --inputs is specified

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 18, 2014

pranay.kanwar
* Fix jordansissel#278 Don't require additional args when --inputs is…
… specified

* --inputs only valid with -s dir
* Strip lines when reading from file from --inputs

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 18, 2014

jls
Merge pull request jordansissel#297 from r4um/fix_278
Fix jordansissel#278 Don't require additional args when --inputs is specified

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 27, 2014

* Fix jordansissel#278 Don't require additional args when --inputs is…
… specified

* --inputs only valid with -s dir
* Strip lines when reading from file from --inputs

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 27, 2014

Merge pull request jordansissel#297 from r4um/fix_278
Fix jordansissel#278 Don't require additional args when --inputs is specified

r4um added a commit that referenced this issue Apr 24, 2015

* Fix #278 Don't require additional args when --inputs is specified
* --inputs only valid with -s dir
* Strip lines when reading from file from --inputs

jordansissel added a commit that referenced this issue Apr 24, 2015

Merge pull request #297 from r4um/fix_278
Fix #278 Don't require additional args when --inputs is specified

jordansissel pushed a commit that referenced this issue Jun 20, 2016

* Fix #278 Don't require additional args when --inputs is specified
* --inputs only valid with -s dir
* Strip lines when reading from file from --inputs

jordansissel added a commit that referenced this issue Jun 20, 2016

Merge pull request #297 from r4um/fix_278
Fix #278 Don't require additional args when --inputs is specified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment