Fix #291 don't trim gem version. #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -111,8 +111,8 @@ def load_package_info(gem_path) | |||
| # expand spec's version to match RationalVersioningPolicy to prevent cases | |||
| # where missing 'build' number prevents correct dependency resolution by target | |||
| # package manager. Ie. for dpkg 1.1 != 1.1.0 | |||
| m = spec.version.to_s.match /^(\d)?.?(\d+)?.?(\d+)?/ | |||
| self.version = m.captures.map {|m| m ? m : 0}.join('.') | |||
| m = spec.version.to_s.scan(/(\d)\.?/) | |||
There was a problem hiding this comment.
i think the \d should be \d+ here
There was a problem hiding this comment.
I'll fix that prior to release.
There was a problem hiding this comment.
ah! yes. Thanks for taking care of it.
jordansissel
added a commit
that referenced
this pull request
Nov 27, 2012
Fix #291 don't trim gem version.
prof-milki
pushed a commit
to prof-milki/xpm
that referenced
this pull request
Dec 18, 2014
Fix jordansissel#291 don't trim gem version.
prof-milki
pushed a commit
to prof-milki/xpm
that referenced
this pull request
Dec 27, 2014
Fix jordansissel#291 don't trim gem version.
jordansissel
added a commit
that referenced
this pull request
Apr 24, 2015
Fix #291 don't trim gem version.
jordansissel
added a commit
that referenced
this pull request
Jun 20, 2016
Fix #291 don't trim gem version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid trimming gem version when there are greater than 3 version sequences.