New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM failure when version has dash #393

Closed
jterrace opened this Issue Apr 1, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@jterrace
Contributor

jterrace commented Apr 1, 2013

If you try and create an RPM package from a Python module that has a dash ("-") in the version:

error: line 24: Illegal char '-' in: Version: 2.8.0-dev {:level=>:error}
Process failed: rpmbuild failed (exit code 1). Full command was:["rpmbuild", "-bb", "--define", "buildroot /tmp/package-rpm-build20130401-14264-jygd3j/BUILD", "--define", "_topdir /tmp/package-rpm-build20130401-14264-jygd3j", "--define", "_sourcedir /tmp/package-rpm-build20130401-14264-jygd3j", "--define", "_rpmdir /tmp/package-rpm-build20130401-14264-jygd3j/RPMS", "/tmp/package-rpm-build20130401-14264-jygd3j/SPECS/python-boto.spec"] {:level=>:error}

It looks like #97 fixed this at some point, but I don't see any remnants of that patch left in the current rpm.rb file.

jordansissel added a commit that referenced this issue Apr 2, 2013

Merge pull request #395 from jterrace/strip-rpm-dash
Replace dashes with underscores in RPM version strings. Fixes #393.

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 18, 2014

jls
Merge pull request jordansissel#395 from jterrace/strip-rpm-dash
Replace dashes with underscores in RPM version strings. Fixes jordansissel#393.

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 27, 2014

Merge pull request jordansissel#395 from jterrace/strip-rpm-dash
Replace dashes with underscores in RPM version strings. Fixes jordansissel#393.

jordansissel added a commit that referenced this issue Apr 24, 2015

Merge pull request #395 from jterrace/strip-rpm-dash
Replace dashes with underscores in RPM version strings. Fixes #393.

jordansissel added a commit that referenced this issue Jun 20, 2016

Merge pull request #395 from jterrace/strip-rpm-dash
Replace dashes with underscores in RPM version strings. Fixes #393.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment