Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM will hang on named pipe #539

Closed
adamcstephens opened this issue Sep 4, 2013 · 6 comments
Labels

Comments

@adamcstephens
Copy link
Contributor

@adamcstephens adamcstephens commented Sep 4, 2013

#511 added FIFO support to fpm, but not the RPM template.
#532 adds FIFO support at least.

@r4um

This comment has been minimized.

Copy link
Contributor

@r4um r4um commented Sep 19, 2013

Fixed via 60e6d15.

@r4um r4um closed this Sep 19, 2013
@adamcstephens

This comment has been minimized.

Copy link
Contributor Author

@adamcstephens adamcstephens commented Sep 25, 2013

This does not fix the problem I submitted the pull request for

/usr/lib/ruby/1.8/fileutils.rb:1257:in `copy': cannot handle FIFO (RuntimeError)
    from /usr/lib/ruby/1.8/fileutils.rb:452:in `copy_entry'
    from /usr/lib/ruby/1.8/fileutils.rb:1331:in `traverse'
    from /usr/lib/ruby/1.8/fileutils.rb:449:in `copy_entry'
    from /usr/lib/ruby/gems/1.8/gems/fpm-0.4.43/lib/fpm/util.rb:140:in `copy_entry'
    from /usr/lib/ruby/gems/1.8/gems/fpm-0.4.43/lib/fpm/package/rpm.rb:380:in `output'
    from /usr/lib/ruby/1.8/find.rb:39:in `find'
    from /usr/lib/ruby/1.8/find.rb:38:in `catch'
    from /usr/lib/ruby/1.8/find.rb:38:in `find'
    from /usr/lib/ruby/gems/1.8/gems/fpm-0.4.43/lib/fpm/package/rpm.rb:376:in `output'
    from /usr/lib/ruby/gems/1.8/gems/fpm-0.4.43/lib/fpm/command.rb:389:in `execute'
    from /usr/lib/ruby/gems/1.8/gems/clamp-0.6.1/lib/clamp/command.rb:67:in `run'
    from /usr/lib/ruby/gems/1.8/gems/fpm-0.4.43/lib/fpm/command.rb:436:in `run'
    from /usr/lib/ruby/gems/1.8/gems/clamp-0.6.1/lib/clamp/command.rb:125:in `run'
    from /usr/lib/ruby/gems/1.8/gems/fpm-0.4.43/bin/fpm:8
    from /usr/bin/fpm:19:in `load'
    from /usr/bin/fpm:19
@r4um

This comment has been minimized.

Copy link
Contributor

@r4um r4um commented Sep 25, 2013

Yeah the whole thing seems broken, thanks @adamcstephens. Will work on a PR

@r4um r4um reopened this Sep 25, 2013
@adamcstephens

This comment has been minimized.

Copy link
Contributor Author

@adamcstephens adamcstephens commented Sep 25, 2013

I did some digging, but I'm not skilled enough in ruby to propose a fix. The issue is that the added code block calls copy_entry with the root of the staging dir, which copy_entry then attempts to recursively copy. Obviously this fails on the FIFO.

@r4um

This comment has been minimized.

Copy link
Contributor

@r4um r4um commented Sep 25, 2013

I did some digging, but I'm not skilled enough in ruby to propose a fix. The issue is that the added code block calls copy_entry with the root of the staging dir, which copy_entry then attempts to recursively copy. Obviously this fails on the FIFO.

Yeah, additionally to that the case statement is wrong (its not C :/), also mknod ffi call is failing on linux with EINVAL.

@r4um

This comment has been minimized.

Copy link
Contributor

@r4um r4um commented Sep 25, 2013

Filed PR #561.

gerbercj pushed a commit to gerbercj/fpm that referenced this issue Feb 27, 2014
gerbercj pushed a commit to gerbercj/fpm that referenced this issue Mar 11, 2014
gerbercj pushed a commit to gerbercj/fpm that referenced this issue Apr 25, 2014
prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 18, 2014
prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 18, 2014
prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 27, 2014
prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 27, 2014
r4um added a commit that referenced this issue Apr 24, 2015
jordansissel added a commit that referenced this issue Apr 24, 2015
Closes #539 Correct mknod implementation
jordansissel pushed a commit that referenced this issue Jun 20, 2016
jordansissel added a commit that referenced this issue Jun 20, 2016
Closes #539 Correct mknod implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.