New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-p works with rpm but not with .deb #656

Closed
spuder opened this Issue Mar 4, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@spuder

spuder commented Mar 4, 2014

Steps to reproduce,

Use fpm to create a .rpm and a .deb. If you use -p the .rpm will succeede while the .deb will fail.

mkdir /tmp/installdir #Where we will save the redis binaries
cd /tmp
wget http://download.redis.io/releases/redis-2.8.6.tar.gz
tar -xvf redis-*.tar.gz
cd redis-2.8.*
PREFIX=/tmp/installdir make 
PREFIX=/tmp/installdirmake install 
mkdir -p /tmp/installdir/etc/init.d/

#Fail
fpm -p /tmp -s dir -m sowen@foo.com -C /tmp/installdir -t deb  -n redis-6390 -v 2.8.6  bin/ etc/ var/

Process failed: ar failed (exit code 1). Full command was:["ar", "-qc", "/tmp", "debian-binary", "control.tar.gz", "/tmp/package-deb-build20140304-28142-nfr1q3/data.tar.gz"] {:level=>:error}

#Success
fpm -p /tmp -s dir -m sowen@foo.com -C /tmp/installdir -t rpm  -n redis-6390 -v 2.8.6  bin/ etc/ var/

no value for epoch is set, defaulting to nil {:level=>:warn}
no value for epoch is set, defaulting to nil {:level=>:warn}
Created rpm {:path=>"/tmp"}

tmp directory

[root@dependencies tmp]# ll /tmp
total 23276
drwxr-xr-x  5 root root     4096 Mar  4 16:02 installdir
-rw-r--r--  1 root root  4158014 Mar  4 16:14 redis-6390-2.8.6-1.x86_64.rpm

It does not matter where in the command the -p is located

https://gist.github.com/spuder/9357799

@spuder spuder closed this Mar 4, 2014

@spuder spuder reopened this Mar 4, 2014

@adamonduty

This comment has been minimized.

Contributor

adamonduty commented Apr 30, 2014

Tests pass on afb0dce, but invoking bin/fpm -f -s dir -t rpm -n example bin/ gives me

/vagrant/fpm/lib/fpm/command.rb:398:in `directory?': no implicit conversion of nil into String (TypeError)
    from /vagrant/fpm/lib/fpm/command.rb:398:in `execute'
    from /home/vagrant/.rvm/gems/ruby-2.0.0-p451/gems/clamp-0.6.3/lib/clamp/command.rb:67:in `run'
    from /vagrant/fpm/lib/fpm/command.rb:457:in `run'
    from /home/vagrant/.rvm/gems/ruby-2.0.0-p451/gems/clamp-0.6.3/lib/clamp/command.rb:125:in `run'
    from bin/fpm:8:in `<main>'

where it didn't the previous commit.

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 18, 2014

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 27, 2014

jordansissel added a commit that referenced this issue Apr 24, 2015

Support being given a directory for the output path (-p flag)
This should fix #656 and maybe a few other things.

jordansissel added a commit that referenced this issue Jun 20, 2016

Support being given a directory for the output path (-p flag)
This should fix #656 and maybe a few other things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment