New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --debug-workspace option #720

Closed
tabletcorry opened this Issue Jun 16, 2014 · 6 comments

Comments

Projects
None yet
2 participants
@tabletcorry
Contributor

tabletcorry commented Jun 16, 2014

It seems the only way to get FPM to keep the work/tmp directories is to push it all the way to --debug mode. This kinda works, but the output becomes incredibly messy.

Also, the fact that --debug does this is not documented, so I only found it by trial and error.

This may be specific to gem builds.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jun 16, 2014

Hmm... I'm open to this, but maybe we can go deeper? Adding tracepoints somewhere in FPM so that with --debug (or --debug-interactive, perhaps, if we added such a creature) to let you use the excellent 'pry' library to poke around fpm at various points of execution?

@tabletcorry

This comment has been minimized.

Contributor

tabletcorry commented Jun 16, 2014

The only issue I have with --debug output is that every line has debug output appended, which is really noisy. See below

If the only thing I want is the source tree in the workdir, this is kinda overkill. I just want to look at the source tree and make/gcc/gem output files to see why it broke.

So, I don't think that prying inside FPM would help, as I want the output of gem. But, I admit ignorance on this point.

Provided configuration options: {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --with-opt-dir {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --without-opt-dir {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --with-opt-include {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --without-opt-include=${opt-dir}/include {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --with-opt-lib {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --without-opt-lib=${opt-dir}/lib {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --with-make-prog {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --without-make-prog {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --srcdir=. {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --curdir {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --ruby=/opt/ruby/2.0/bin/ruby {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --help {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --clean {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
    --use-system-libraries {:level=>:info, :file=>"cabin/mixins/pipe.rb", :line=>"46"}
@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jun 16, 2014

Hmm.. How about a --debug-workspace that will prevent removal of staging/build directories for all packages and tell you in output what those paths are?

Specifically proposing that --debug-workspace would

  • not set the loglevel changes
  • disable cleanup of build/staging directories
  • cause fpm to emit on stdout the paths for each staging/build directory.

Thoughts? Preferred format?

@tabletcorry

This comment has been minimized.

Contributor

tabletcorry commented Jun 16, 2014

That sounds pretty good.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jun 16, 2014

FRIENDSHIP ACHIEVED.

@jordansissel jordansissel changed the title from Add a --keep-work option? to Add a --debug-workspace option Jun 16, 2014

jordansissel added a commit that referenced this issue Jun 19, 2014

Add --debug-workspace
Avoids Package#cleanup calls and also prints the paths, if not empty, of
any build or staging directories used for input or output.

Fixes #720
@tabletcorry

This comment has been minimized.

Contributor

tabletcorry commented Jul 10, 2014

🎉 👍

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 18, 2014

jls
Add --debug-workspace
Avoids Package#cleanup calls and also prints the paths, if not empty, of
any build or staging directories used for input or output.

Fixes jordansissel#720

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 27, 2014

Add --debug-workspace
Avoids Package#cleanup calls and also prints the paths, if not empty, of
any build or staging directories used for input or output.

Fixes jordansissel#720

jordansissel added a commit that referenced this issue Apr 24, 2015

Add --debug-workspace
Avoids Package#cleanup calls and also prints the paths, if not empty, of
any build or staging directories used for input or output.

Fixes #720

jordansissel added a commit that referenced this issue Jun 20, 2016

Add --debug-workspace
Avoids Package#cleanup calls and also prints the paths, if not empty, of
any build or staging directories used for input or output.

Fixes #720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment