Blank URL in rpm spec causes issues #82

Closed
tabletcorry opened this Issue Jul 26, 2011 · 4 comments

Comments

Projects
None yet
2 participants
Contributor

tabletcorry commented Jul 26, 2011

It looks like an edge case appears when a gem is converted to an rpm, and the url is defined but zero length.

As an example, when I try to convert fastthread-1.0.7 to an rpm, it explodes because the rpmspec is created with an empty URL.

jneen added a commit that referenced this issue Jul 27, 2011

Collaborator

jneen commented Jul 27, 2011

Augh, issues everywhere. @tabletcorry, the commit above should work, but I don't have a test setup with rpmbuild. Can you verify that it works?

Contributor

tabletcorry commented Jul 27, 2011

Sure, give me a few minutes to try it out.

Contributor

tabletcorry commented Jul 27, 2011

Looks like it works. Though, with that change, you no longer need any of the logic in the rpm template for URL.

Collaborator

jneen commented Jul 27, 2011

Awesome, good to hear. I'll merge it in (without the logic in the template :).

@jneen jneen closed this Jul 27, 2011

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 18, 2014

prof-milki pushed a commit to prof-milki/xpm that referenced this issue Dec 27, 2014

jneen added a commit that referenced this issue Apr 24, 2015

jordansissel pushed a commit that referenced this issue Jun 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment