New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global architecture switch for FreeBSD ABI #1196

Merged
merged 1 commit into from Oct 16, 2016

Conversation

Projects
None yet
2 participants
@hatt
Contributor

hatt commented Sep 28, 2016

Alternative implementation of #1140. I'm not super happy with the way the casing works but I think this can extend to cover platforms like ARM, MIPS, SPARC, etc down the track. There is a pseudo-authoritative list of valid architecture and wordsize options here but I've only really kept the x86 parts of it. Since i386 and x86_64 both use the same architecture (x86), I've just set this as is for now.

Overall I feel like this implementation is ugly but I can't think of a nicer way to do it. This is at least more consistent with what the other package architecture mutators do, like for RPM or Deb.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Oct 16, 2016

Wooo <3

@jordansissel jordansissel merged commit 0926aa1 into jordansissel:master Oct 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hatt hatt deleted the hatt:task/1140-update-freebsd-arch branch Oct 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment