Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make virtualenv packages truly standalone #1218

Merged
merged 2 commits into from Dec 7, 2016

Conversation

@nzjrs
Copy link
Contributor

nzjrs commented Oct 23, 2016

this branch contains two improvements to allow using fpm to distribute end user python applications and their dependencies together, in one virtualenv based package.

nzjrs added 2 commits Oct 23, 2016
one common use-case for a virtualenv requirements.txt source
is to distribute ones software and the dependencies in one
debian file. unfortunately the current implementation doesn't
get one all the way to that goal. Starting with a local checkout
of a python package (containing one's own software, setup.py and
requirements.txt) fpm can create a package that contains the
software dependencies, but not the software itself.

this commit adds an option to also run the package setup.py
after populating the virtualenv, thus giving a means to
package one's own application *and* the dependencies in
one step
this allows virtualenv packages to see the system package
directory
@nzjrs nzjrs changed the title virtualenv improvements make virtualenv packages truly standalone Nov 1, 2016
@nzjrs

This comment has been minimized.

Copy link
Contributor Author

nzjrs commented Nov 1, 2016

ping? this is a pretty large increase in functionality for a handful of lines of code

@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Dec 7, 2016

Code looks good. I wish for tests, but I won't block on it.

@jordansissel jordansissel merged commit af305e7 into jordansissel:master Dec 7, 2016
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Dec 7, 2016

Thank you very much for this improvement! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.