New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use StringIO from ruby stdlib #1231

Merged
merged 1 commit into from Nov 23, 2016

Conversation

Projects
None yet
2 participants
@josegonzalez
Collaborator

josegonzalez commented Nov 22, 2016

Closes #1148

@josegonzalez

This comment has been minimized.

Collaborator

josegonzalez commented Nov 22, 2016

Test failures on OS X seem to be due to TravisCI environment changes and fpm potentially pointing at the wrong python during tests?

@josegonzalez josegonzalez force-pushed the josegonzalez:patch-1 branch from 527fdba to 098c9b2 Nov 22, 2016

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Nov 23, 2016

@josegonzalez Confession: I have reacted to the TravisCI OSX failures (for many months, it seems, now) by simply ignoring them. I only look at the Linux results on Travis.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Nov 23, 2016

LGTM

@jordansissel jordansissel merged commit 9b854df into jordansissel:master Nov 23, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@josegonzalez josegonzalez deleted the josegonzalez:patch-1 branch Nov 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment