New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In case of a=b syntax where a is symlink, don't create directory #1253

Merged
merged 1 commit into from Jul 20, 2017

Conversation

Projects
None yet
2 participants
@nemanja-boric-sociomantic
Contributor

nemanja-boric-sociomantic commented Dec 5, 2016

Previously, if the symlink is included into the package and specified
with

my-sym-link.so=/usr/lib/my-sym-link.so

fpm would create directory, and put the
symlink inside `/usr/lib/my-sym-link.so/my-sym-link.so
which is very surprising and it doesn't follow the same
pattern as file copying is doing.

In case of a=b syntax where a is symlink, don't create directory
Previously, if the symlink is included into the package and specified
with

my-sym-link.so=/usr/lib/my-sym-link.so

fpm would create directory, and put the
symlink inside `/usr/lib/my-sym-link.so/my-sym-link.so
which is very surprising and it doesn't follow the same
pattern as file copying is doing.

Fixes #1135

@nemanja-boric-sociomantic nemanja-boric-sociomantic force-pushed the nemanja-boric-sociomantic:fixsymlink branch from d5e720f to 2e2ee84 Dec 5, 2016

@nemanja-boric-sociomantic

This comment has been minimized.

Contributor

nemanja-boric-sociomantic commented Dec 5, 2016

I've added the test specifications for symlinks. Also the failure doesn't seems to be related to this PR, but something else is broken.

@jordansissel jordansissel merged commit fcd4dfd into jordansissel:master Jul 20, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jul 20, 2017

Thank you for this improvement :)

@nemanja-boric-sociomantic nemanja-boric-sociomantic deleted the nemanja-boric-sociomantic:fixsymlink branch Aug 7, 2017

nemanja-boric-sociomantic added a commit to nemanja-boric-sociomantic/fpm that referenced this pull request Aug 9, 2017

Allow source=dest/ syntax for symlinks
PR jordansissel#1253, while fixed the bug where `source.link=dest/source.link`
resulted in `source.link=dest/source.link/source.link` introduced a bug
where `source=dest/` syntax stopped working for symlinks (it is ok for
files). This is now fixed, as the symlink source now behaves the same as
it would with a single file input. Test case testing this behaviour is
also added.

Fixes jordansissel#1395

jordansissel added a commit that referenced this pull request Sep 11, 2017

Allow source=dest/ syntax for symlinks
PR #1253, while fixed the bug where `source.link=dest/source.link`
resulted in `source.link=dest/source.link/source.link` introduced a bug
where `source=dest/` syntax stopped working for symlinks (it is ok for
files). This is now fixed, as the symlink source now behaves the same as
it would with a single file input. Test case testing this behaviour is
also added.

Fixes #1395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment