Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be consistent in letting newer Perl module versions meet the requirement, if not otherwise specified #1338

Merged
merged 1 commit into from Jun 5, 2017

Conversation

@rjbell4
Copy link
Contributor

rjbell4 commented Jun 5, 2017

Note that this is the same comparison a few lines later (line 179). Without this change, I would never get all the Perl modules aligned perfectly. As far as I can determine, this is what CPAN is enforcing, anyway.

@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Jun 5, 2017

Can you add a comment above the line you changed to indicate your reasoning? (I see it in the PR description, but for future authors/readers it might be helpful to say this in the code comment as well)

…ents, if not otherwise specified
@rjbell4 rjbell4 force-pushed the rjbell4:perlflexver branch from 16aa45f to 187df78 Jun 5, 2017
@rjbell4

This comment has been minimized.

Copy link
Contributor Author

rjbell4 commented Jun 5, 2017

Sure. Done.

@jordansissel jordansissel merged commit f393ca6 into jordansissel:master Jun 5, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Jun 5, 2017

@rjbell4 awesome, thank you :)

@rjbell4 rjbell4 deleted the rjbell4:perlflexver branch Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.