New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove the leading "v" from version dependencies #1339

Merged
merged 1 commit into from Jun 5, 2017

Conversation

Projects
None yet
3 participants
@rjbell4
Contributor

rjbell4 commented Jun 5, 2017

This is how the version of those dependencies themselves are being provided. I ran into this with Kafka::Librd and Alien::Librdkafka. Removing this code allowed the versioning to be correctly checked.

Do not remove the leading "v" from version dependencies, since that i…
…s how the version of those dependencies themselves are being provided
@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jun 5, 2017

Interesting... This was added in 93dacaf (for #1239). It's hard to tell if this is working since this is still using the now-gone v0 api.

Any tips for testing this?

@rjbell4

This comment has been minimized.

Contributor

rjbell4 commented Jun 5, 2017

I should have git blamed it to learn more. FYI, for anyone else reading, it's #1236.

It's interesting to think if this change is in part due to v1 of the API ... though I think it may have been failing before v0 went away. The downloading does seem to be working with the v1 API, at least, so if that's what the reason was, perhaps it no longer applies?

This is the module in question that was causing me problems: https://metacpan.org/pod/Alien::Librdkafka

(which I needed for Kafka::Librd)

@rjbell4

This comment has been minimized.

Contributor

rjbell4 commented Jun 5, 2017

FWIW, the following command worked on Ubuntu 16.10:
bin/fpm -s cpan -t deb Rex::Repositorio
And the following worked on SLES12 SP1:
bin/fpm -s cpan -t rpm Rex::Repositorio

Since the problem was originally reported with Rex-Repositorio, I'm going to guess that this means that there is no regression with this change.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jun 5, 2017

@rjbell4 Thanks for the extra testing. I think this is good to merge.

@jordansissel jordansissel merged commit 5148814 into jordansissel:master Jun 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@liger1978

This comment has been minimized.

Contributor

liger1978 commented Jun 5, 2017

#1236 Was mine. It was certainly needed at the time.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jun 5, 2017

@liger1978 any chance you can try master and see if it works for you? No pressure.

@liger1978

This comment has been minimized.

Contributor

liger1978 commented Jun 6, 2017

For converting Beanstalk::Client to rpm, I get:

/usr/local/share/gems/bundler/gems/fpm-32d526fb14cf/lib/fpm/package/cpan.rb:102:in `+': no implicit conversion of Float into String (TypeError)
	from /usr/local/share/gems/bundler/gems/fpm-32d526fb14cf/lib/fpm/package/cpan.rb:102:in `block in input'
	from /usr/local/share/gems/bundler/gems/fpm-32d526fb14cf/lib/fpm/package/cpan.rb:101:in `each'
	from /usr/local/share/gems/bundler/gems/fpm-32d526fb14cf/lib/fpm/package/cpan.rb:101:in `input'
	from build.rb:229:in `cpan2rpm'
	from build.rb:666:in `block in <main>'
	from build.rb:649:in `each'
	from build.rb:649:in `<main>'

Line 102 is here: https://github.com/jordansissel/fpm/blob/master/lib/fpm/package/cpan.rb#L102

I think this error relates to the new capabilities functionality in #1340, rather than this issue though.

@liger1978

This comment has been minimized.

Contributor

liger1978 commented Jun 6, 2017

Changing self.version to "#{self.version}" in line 102 should fix it, but need to sleep now.

@liger1978

This comment has been minimized.

Contributor

liger1978 commented Jun 6, 2017

Opened #1343 for this. Will attempt a fix.

@rjbell4 rjbell4 deleted the rjbell4:perlnov branch Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment