Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --python-setup-py-arguments flag which can be used to pass arbitrary arguments to setup.py. #1376

Merged
merged 1 commit into from Jul 21, 2017

Conversation

@josephholsten
Copy link
Collaborator

josephholsten commented Jul 21, 2017

updated #1120

arguments to setup.py.

This is helpful to package python modules that have a poorly written
setup.py that requires special arguments.
@@ -310,6 +314,13 @@ def install_to_staging(setup_py)
flags += [ "build_scripts", "--executable", attributes[:python_scripts_executable] ]
end

if !attributes[:python_setup_py_arguments].nil? and !attributes[:python_setup_py_arguments].empty?

This comment has been minimized.

Copy link
@jordansissel

jordansissel Jul 21, 2017

Owner

this won't ever be nil because the default is [] (empty array), but there's probably no harm in this nil check.

@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Jul 21, 2017

I reviewed #1120 and this PR. Seems safe to merge.

@jordansissel jordansissel merged commit 5567242 into master Jul 21, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jordansissel jordansissel deleted the new-1120 branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.