New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes typo with APK control scripts #1422

Merged
merged 1 commit into from Jan 11, 2018

Conversation

Projects
None yet
2 participants
@charlesportwoodii
Contributor

charlesportwoodii commented Oct 14, 2017

Alpine Linux describes the available control scripts at https://wiki.alpinelinux.org/wiki/Creating_an_Alpine_package.

This patch fixes an issue where post-install was registered multiple times, preventing :after_install, :before_install, :before_upgrade, and :after_upgrade from running the correct script if multiple options were declared.

The issue appeared in 87ce028.

Fixes typo with APK control scripts
Alpine Linux describes the available control scripts at https://wiki.alpinelinux.org/wiki/Creating_an_Alpine_package.

This patch fixes an issue where `post-install` was registered multiple times, preventing `:after_install`, `:before_install`, `:before_upgrade`, and `:after_upgrade` from running the correct script.

charlesportwoodii added a commit to charlesportwoodii/php-fpm-build that referenced this pull request Oct 14, 2017

Consolodating common and cli since common was almost empty.
Discovered jordansissel/fpm#1422, which prevents Alpine packages from being built correctly [ci skip]
@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jan 11, 2018

I don't' have tests to verify this, but the change looks correct to me. Merging!

@jordansissel jordansissel merged commit b3c20f4 into jordansissel:master Jan 11, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment