Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non ruby programmer attempt to fix config-file issue with deb packages #1443

Merged
merged 3 commits into from Dec 23, 2017

Conversation

@NoBodyCam
Copy link
Contributor

NoBodyCam commented Nov 17, 2017

This is a fix to correct a Issue I am running into (#1440) when creating deb packages with the config-files option.

NoBodyCam added 2 commits Nov 17, 2017
While I am not a ruby programer, I was able to come up with a solution to
the issue I was running into when attempting to create a .deb package when
using the --config-files option.
@NoBodyCam

This comment has been minimized.

Copy link
Contributor Author

NoBodyCam commented Nov 17, 2017

I do not believe my patch is the cause of the test failures. Looking at the output of the tests I am seeing: perl failed (exit code 2).

Check if config file already exists in the staging before attempting
to copy it
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Dec 23, 2017

I like the proposed change. I'd like to see tests added, but I may write these before merging. If you are interested, please let me know :)

@jordansissel jordansissel merged commit 90a7f94 into jordansissel:master Dec 23, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.