Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
python3 fix #1482
I just attached explanation link for this syntax rules. It looks correct for me, but some reviewers can have a questions and I need a new release :-) пн, 7 мая 2018 г., 19:46 Roman Vasilyev <firstname.lastname@example.org>:…
***@***.**** commented on this pull request. ------------------------------ In lib/fpm/package/python.rb <#1482 (comment)>: > @@ -240,7 +240,7 @@ def load_package_info(setup_py) next if attributes[:python_disable_dependency].include?(name) # convert == to = - if cmp == "==" + if cmp == "==" or cmp == "~=" it still not clear to me what wrong with this code? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1482 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APSmM7emgiPp-S_904kSFBkoguk3YDs6ks5twIiQgaJpZM4TLvkD> .
This change looks OK to me. I tested manually, and was successful
This seems successful.
One thing that confused me is that the azure egg has no files. This seems correct.
That said, I compared this to the azure-3.0.0.zip from https://pypi.org/project/azure/#files, and it also doesn't have any python files:
Unfortunately, this PR is not correct. The
Maybe I'll write a patch when bored.