New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Follow best practices #1484

Merged
merged 1 commit into from May 13, 2018

Conversation

Projects
None yet
2 participants
@allanlewis
Contributor

allanlewis commented Apr 13, 2018

In order to follow best practice for Dockerfiles, this commit:

  • Removes leading and trailing blank lines.
  • Pins the base image to a specific version of Alpine; the latest, 3.7, is used.
  • Tells apk to not cache any package lists.
  • Puts each dependency on its own line.
  • Does some minor reformatting for readability.
Dockerfile: Follow best practices
In order to follow best practice for Dockerfiles, this commit:

* Removes leading and trailing blank lines.
* Pins the base image to a specific version of Alpine; the latest, 3.7, is used.
* Tells `apk` to not cache any package lists.
* Puts each dependency on its own line.
* Does some minor reformatting for readability.
@jordansissel

I don't know how to evaluate the 'best practice' claim. It's likely that such a claim doesn't need evaluation, so I'll do a functionality test:

% docker build .
Successfully built 7ce8cc76d53b

% docker run  -it 7ce8cc76d53b fpm --version
1.9.3

LGTM

@jordansissel jordansissel merged commit 005baa9 into jordansissel:master May 13, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@allanlewis allanlewis deleted the allanlewis:patch-1 branch May 14, 2018

@allanlewis

This comment has been minimized.

Contributor

allanlewis commented May 14, 2018

Thanks, @jordansissel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment