New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perl CPAN Support, Fix Broken PERL5LIB & Add cpanm Verbose Option #1511

Merged
merged 2 commits into from Jul 4, 2018

Conversation

Projects
None yet
2 participants
@wbraswell
Contributor

wbraswell commented Jul 4, 2018

Fixed #1510

@wbraswell

This comment has been minimized.

Contributor

wbraswell commented Jul 4, 2018

@jordansissel
sorry for the confusion, I just figured the fastest solution was to close the old pull request and open a new one with the fix

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jul 4, 2018

Thank you for working on this! Code change looks good. I am testing now :)

@jordansissel jordansissel self-assigned this Jul 4, 2018

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jul 4, 2018

I tested manually the following:

% bin/fpm --verbose --no-cpan-test -s cpan -t deb Alien::PCRE2

  • master: fails as expected by #1509
  • this pr: ✔️ Created package {:path=>"perl-alien-jpcre2_0.012000_all.deb"}

Confirmed this fixes #1509

The test suite (rspec spec/fpm/package/cpan_spec.rb) fails 1 of 3 tests, but this same failure happens on master, so I do not believe this PR caused any test failures.

LGTM :)

@jordansissel jordansissel merged commit 7f5538f into jordansissel:master Jul 4, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jul 4, 2018

I'll prepare a release now.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Jul 4, 2018

Pushing gem to https://rubygems.org...
Successfully registered gem: fpm (1.10.1)

This PR is now published in fpm v1.10.1 -- thank you for the fast fix :)

@wbraswell

This comment has been minimized.

Contributor

wbraswell commented Jul 4, 2018

wow great!
I have just now found another unrelated bug, will create a new issue momentarily...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment