New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always treat perl dependency version as a string. #1515

Merged
merged 1 commit into from Jul 4, 2018

Conversation

Projects
None yet
2 participants
@jordansissel
Owner

jordansissel commented Jul 4, 2018

Perl modules have both META.json and META.yml. In the JSON, the perl
dependency appears as a string "5.004", but in YAML it appears as a
number 5.004! This may cause fpm to fail when trying to convert the
perl version into a dependency, so we now always treat the perl version
as a string.

Hopefully fixes #1514

Always treat perl dependency version as a string.
Perl modules have both META.json and META.yml. In the JSON, the perl
dependency appears as a string `"5.004"`, but in YAML it appears as a
number `5.004`! This may cause fpm to fail when trying to convert the
perl version into a dependency, so we now always treat the perl version
as a string.

Hopefully fixes #1514
@wbraswell

This comment has been minimized.

Contributor

wbraswell commented Jul 4, 2018

quick test shows this works, giving more rigorous test now, will let you know shortly

@wbraswell

This comment has been minimized.

Contributor

wbraswell commented Jul 4, 2018

I think we're good!

@jordansissel jordansissel merged commit 20e89a6 into master Jul 4, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment