Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Make the --exclude argument work by removing the excluded paths from the staging directory #186
Thanks for the patch!
I'll have a ponder about how the api change (Adding #exclude to Package) since I'm not totally sold on that - perhaps there's a better way? This way feels weird. Still, I want to get this functioning again, so even if I can't come up with something that feels a bit smoother I'll merge this as-is, since it looks ok :)
I've been testing this patch since I really need to the exclude functionality but I cant seem to get it working
still adds .git folder/files.
Also tested: --exclude ".gitignore" and --exlude "*/.gitignore"
The interface that I've been using for exclude is that of Dir.glob, rooted in the prefixed directory. So, to ignore .git, you'd just use --exclude=.git (I don't know if this is a change from the previous implementation)
As for adding exclude cleanup into package#convert, that should work fine. The exclude paths are already added as an attribute to the package (along with all of the other commandline arguments).
fpm failing w/o exclude is no good. I'll fix that up asap.