New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: already initialized constant #198

Merged
merged 1 commit into from Apr 25, 2012

Conversation

Projects
None yet
2 participants
@mv
Contributor

mv commented Apr 4, 2012

Hi,

I was playing with fpm and took the liberty to remove some warnings regarding already defined constants.

I hope you can use it.

Best,

Marcus

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Apr 4, 2012

I still haven't figured out why this happens. It seems like it's a bug in Ruby 1.8.x that the warning shows up.

@mv

This comment has been minimized.

Contributor

mv commented Apr 4, 2012

Yes, I believe you. You do not redefine those constants anywhere else. Even so I figured an 'unless' made the warnings go away.

jordansissel added a commit that referenced this pull request Apr 25, 2012

Merge pull request #198 from mv/master
Warning: already initialized constant

@jordansissel jordansissel merged commit d69dd68 into jordansissel:master Apr 25, 2012

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Apr 25, 2012

Not super happy with the solution here, but I'm not bothered enough by it to really dig into why ruby does this.

Thanks for the patch! :)

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#198 from mv/master
Warning: already initialized constant

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#198 from mv/master
Warning: already initialized constant

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #198 from mv/master
Warning: already initialized constant

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #198 from mv/master
Warning: already initialized constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment