New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the path_prefix to prefix to allow overriding the gem path #213

Merged
merged 1 commit into from Apr 26, 2012

Conversation

Projects
None yet
2 participants
@vStone
Contributor

vStone commented Apr 26, 2012

Current situation:

$ fpm -s gem -t rpm fpm
$ rpm -qlp rubygem-fpm-0.4.8-1.noarch.rpm
/home/jan/.gem/ruby/1.8/bin/fpm
/home/jan/.gem/ruby/1.8/bin/fpm-npm
/home/jan/.gem/ruby/1.8/cache/fpm-0.4.8.gem
...

Without the patch, its impossible to use

$ fpm --prefix /usr/lib/ruby/gems/1.8 ...

There is some code in there that references path_prefix but I couldn't find that anywhere in the rest of the code so I changed path_prefix to prefix and added a sanity check (if prefix is nil, dont use it)

After patch:

$ fpm -s gem -t rpm --prefix /usr/lib/ruby/gems/1.8 --gem-bin-path /usr/bin fpm
$ rpm -qlp rubygem-fpm-0.4.8-1.noarch.rpm
/usr/bin/fpm
/usr/bin/fpm-npm
/usr/lib/ruby/gems/1.8/cache/fpm-0.4.8.gem
...
@jordansissel

This comment has been minimized.

Owner

jordansissel commented Apr 26, 2012

ahh, good catch!

jordansissel added a commit that referenced this pull request Apr 26, 2012

Merge pull request #213 from UnifiedPost/develop
Fixed the path_prefix to prefix to allow overriding the gem path

@jordansissel jordansissel merged commit c52e1ac into jordansissel:master Apr 26, 2012

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#213 from UnifiedPost/develop
Fixed the path_prefix to prefix to allow overriding the gem path

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#213 from UnifiedPost/develop
Fixed the path_prefix to prefix to allow overriding the gem path

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #213 from UnifiedPost/develop
Fixed the path_prefix to prefix to allow overriding the gem path

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #213 from UnifiedPost/develop
Fixed the path_prefix to prefix to allow overriding the gem path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment