Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 245 (RPM's with non-root owners doesn't set ownership of directori... #260

Merged
merged 1 commit into from Nov 8, 2012

Conversation

@ajf8
Copy link
Contributor

ajf8 commented Sep 11, 2012

Hi,

I've added a --directories argument to FPM which causes the values to be added as %dir entries under the file list, so they take the --rpm-user and --rpm-group as owners and get removed when the RPM gets removed. As you can see, it works just like --config-files.

What do you think?

Thanks and Regards,

…ories). Add a --directories argument, which in a similar way to --config-files allows directories to be tagged as directories, meaning they are owned by the RPM. This means they get the --rpm-user and --rpm-group as their owners, and they are removed with the RPM.
@davidmccormick

This comment has been minimized.

Copy link

davidmccormick commented Sep 28, 2012

Hi, this sounds good, as it solves our problem of ensuring that our directories are getting created with the right users/groups- thanks!

Could it be taken further? It would be FANTASTICALLY-USEFUL if there were a way of defining per file/directory permissions within the resultant RPM (which is possible when using a spec file). I don't know what would be the best way of assigning the permissions?

  1. A simple list file - lists the files/directories and their permissions (bit like a spec)
  2. A switch that copies the source owner, group and permissions (and perhap SELinux contexts) and add them to the spec file/ resultant RPM. like this idea sounds like a simple concept, much like preserving permissions in a copy or archive.
  3. A convention for defining the owner, group, mode etc,, within the filename which then get stripped off again.

regards

Dave

@robertlacroix

This comment has been minimized.

Copy link

robertlacroix commented Nov 8, 2012

Patch works great for me, I'd love to see it merged.

@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Nov 8, 2012

LGTM.

jordansissel added a commit that referenced this pull request Nov 8, 2012
issue 245 (RPM's with non-root owners doesn't set ownership of directori...
@jordansissel jordansissel merged commit 4b6d3b3 into jordansissel:master Nov 8, 2012
1 check passed
1 check passed
default The Travis build passed
Details
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Nov 8, 2012

@davidmccormick - Definitely interested in such a feature, can you file a separate issue about it? We can discuss behavior/interfaces there. :)

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014
issue 245 (RPM's with non-root owners doesn't set ownership of directori...
prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014
issue 245 (RPM's with non-root owners doesn't set ownership of directori...
jordansissel added a commit that referenced this pull request Apr 24, 2015
issue 245 (RPM's with non-root owners doesn't set ownership of directori...
jordansissel added a commit that referenced this pull request Jun 20, 2016
issue 245 (RPM's with non-root owners doesn't set ownership of directori...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.