Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace % with [%] to make rpm not expand macros in file names #266

Merged
merged 2 commits into from Sep 26, 2012

Conversation

@jwittkoski
Copy link
Contributor

jwittkoski commented Sep 25, 2012

File names can have percents in them and rpm is... rpm, so stop the macro replacement madness.

Macro replacement is usually not an issue unless your file name contains something like "%name%" or another defined macro. (I'm looking at you, rails.)

@jwittkoski

This comment has been minimized.

Copy link
Contributor Author

jwittkoski commented Sep 25, 2012

Should fix issue #222.

jordansissel added a commit that referenced this pull request Sep 26, 2012
Replace % with [%] to make rpm not expand macros in file names
@jordansissel jordansissel merged commit 0ed0021 into jordansissel:master Sep 26, 2012
1 check passed
1 check passed
default The Travis build passed
Details
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Sep 26, 2012

Thanks! I'll write a test case to make sure this works in future releases.

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014
Replace % with [%] to make rpm not expand macros in file names
prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014
Replace % with [%] to make rpm not expand macros in file names
jordansissel added a commit that referenced this pull request Apr 24, 2015
Replace % with [%] to make rpm not expand macros in file names
jordansissel added a commit that referenced this pull request Jun 20, 2016
Replace % with [%] to make rpm not expand macros in file names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.