New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpkg vs rubygem version dependency #269

Merged
merged 1 commit into from Oct 11, 2012

Conversation

Projects
None yet
2 participants
@radim
Contributor

radim commented Oct 4, 2012

Hi,

I would like to verify what's causing the following issue between gem -> deb dependencies. Using FPM to convert all necessary Chef gems into Debian packages. Chef gem itself depends on net-ssh-multi ~> 1.1.0, but net-ssh-multi gem turns as debian package version 1.1.

This causes issue where dpkg >= 1.1.0 dependency can't be satisfied by rubygem-net-ssh-multi-1.1 package.

Is this dpkg issue or is the better way to enforce Rubygems version to always include build number, i.e 1.1 -> 1.1.0 (so far using this fix as temporary workaround).

Thanks

Radim

@radim

This comment has been minimized.

Contributor

radim commented Oct 1, 2012

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Oct 1, 2012

I don't know what you mean when you say 'net-ssh-multi turns into version 1.1 - here's what I see:

% ruby bin/fpm -s gem -t deb -v 1.1.0 net-ssh-multi
Successfully installed net-ssh-multi-1.1
1 gem installed
Created deb package {"path":"rubygem-net-ssh-multi_1.1.0_all.deb"}

# See what the package version is
% ar p rubygem-net-ssh-multi_1.1.0_all.deb control.tar.gz | tar -zx ./control 
% grep Version ./control
Version: 1.1.0
@jordansissel

This comment has been minimized.

Owner

jordansissel commented Oct 1, 2012

oooh I see now! The net-ssh-multi has an actual release versioned literally as "1.1" (http://rubygems.org/gems/net-ssh-multi/versions/1.1)

I think your patch is probably a decent solution to this.

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Oct 1, 2012

Want to send a pull request for your patch? Can you also include in the code a comment above your patch that explains the purpose of it - that way it's easier to later :)

jordansissel added a commit that referenced this pull request Oct 11, 2012

Merge pull request #269 from radim/master
dpkg vs rubygem version dependency

@jordansissel jordansissel merged commit 34dbd7f into jordansissel:master Oct 11, 2012

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Oct 11, 2012

Thanks! :)

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#269 from radim/master
dpkg vs rubygem version dependency

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#269 from radim/master
dpkg vs rubygem version dependency

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #269 from radim/master
dpkg vs rubygem version dependency

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #269 from radim/master
dpkg vs rubygem version dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment