Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank line being added to deb control file, which is causing errors. #288

Merged
merged 1 commit into from Nov 9, 2012

Conversation

@andrewbunday
Copy link
Contributor

andrewbunday commented Nov 9, 2012

Hi,

Updated our install of fpm today and caught this bug.
Here's a minor change to fix a typo on the comments in the templates/deb.erb file.

template file. (added '-' to the end tag).

Without the edit, the template was inserting an extra blank line into the
config file. When dpkg/reprepro try to read the file the blank line is
interpreted as the end of the configuration, and the additional lines
below it cause an error.

With the edit, no additional blank line is inserted. The comment is
correctly escaped.

Signed-off-by: Andrew Bunday andrew.bunday@gmail.com

Thanks,

A,.

template file. (added '-' to the end tag).

Without the edit, the template was inserting an extra blank line into the
config file. When dpkg/reprepro try to read the file the blank line is
interpreted as the end of the configuration, and the additional lines
below it cause an error.

With the edit, no additional blank line is inserted. The comment is
correctly escaped.

Signed-off-by: Andrew Bunday <andrew.bunday@gmail.com>
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Nov 9, 2012

Reminds me, I hope to have lintian integrated into the test suite soon so I can hopefully avoid bugs like thsi in the future ;)

jordansissel added a commit that referenced this pull request Nov 9, 2012
Fix blank line being added to deb control file, which is causing errors.
@jordansissel jordansissel merged commit f77b662 into jordansissel:master Nov 9, 2012
1 check passed
1 check passed
default The Travis build passed
Details
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Nov 9, 2012

Thanks for the detailed explaination of this patch as well as the patch! :)

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014
Fix blank line being added to deb control file, which is causing errors.
prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014
Fix blank line being added to deb control file, which is causing errors.
jordansissel added a commit that referenced this pull request Apr 24, 2015
Fix blank line being added to deb control file, which is causing errors.
jordansissel added a commit that referenced this pull request Jun 20, 2016
Fix blank line being added to deb control file, which is causing errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.