Fix blank line being added to deb control file, which is causing errors. #288

Merged
merged 1 commit into from Nov 9, 2012

2 participants

@andrewbunday

Hi,

Updated our install of fpm today and caught this bug.
Here's a minor change to fix a typo on the comments in the templates/deb.erb file.

template file. (added '-' to the end tag).

Without the edit, the template was inserting an extra blank line into the
config file. When dpkg/reprepro try to read the file the blank line is
interpreted as the end of the configuration, and the additional lines
below it cause an error.

With the edit, no additional blank line is inserted. The comment is
correctly escaped.

Signed-off-by: Andrew Bunday andrew.bunday@gmail.com

Thanks,

A,.

@andrewbunday andrewbunday Very minor edit. Fixing an incorrectly escaped comment in the deb erb
template file. (added '-' to the end tag).

Without the edit, the template was inserting an extra blank line into the
config file. When dpkg/reprepro try to read the file the blank line is
interpreted as the end of the configuration, and the additional lines
below it cause an error.

With the edit, no additional blank line is inserted. The comment is
correctly escaped.

Signed-off-by: Andrew Bunday <andrew.bunday@gmail.com>
50eba5f
@jordansissel
Owner

Reminds me, I hope to have lintian integrated into the test suite soon so I can hopefully avoid bugs like thsi in the future ;)

@jordansissel jordansissel merged commit f77b662 into jordansissel:master Nov 9, 2012

1 check passed

Details default The Travis build passed
@jordansissel
Owner

Thanks for the detailed explaination of this patch as well as the patch! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment