New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding feature: --no-depends flag for deb and rpm #289

Merged
merged 2 commits into from Nov 15, 2012

Conversation

Projects
None yet
2 participants
@dnbert
Contributor

dnbert commented Nov 14, 2012

This commit introduces a new CLI option of "--no-depends". The --no-depends option allows users to request that no dependency be added to their Spec or Control files.

Here is the result of the rspec:

bundle exec rspec
Skipping RPM#output tests because 'rpmbuild' isn't in your PATH {"level":"warn"}
.....Successfully installed example-1.0
1 gem installed
.Successfully installed example-1.0
1 gem installed
.Successfully installed example-1.0
1 gem installed
............................running install
running build
running install_egg_info
Creating /tmp/package-python-staging20121114-19003-cq5oea/usr/local/lib/python2.6/dist-packages/
Writing /tmp/package-python-staging20121114-19003-cq5oea/usr/local/lib/python2.6/dist-packages/example-1.0.egg-info
.running install
running build
running install_egg_info
Creating /tmp/package-python-staging20121114-19003-ofcd6b/usr/local/lib/python2.6/dist-packages/
Writing /tmp/package-python-staging20121114-19003-ofcd6b/usr/local/lib/python2.6/dist-packages/example-1.0.egg-info
.running install
running build
running install_egg_info
Creating /tmp/package-python-staging20121114-19003-1hl0zty/usr/local/lib/python2.6/dist-packages/
Writing /tmp/package-python-staging20121114-19003-1hl0zty/usr/local/lib/python2.6/dist-packages/example-1.0.egg-info
..........................

Finished in 2.98 seconds
63 examples, 0 failures

@@ -43,9 +43,11 @@ Vendor: <%= vendor %>
URL: <%= url or "http://nourlgiven.example.com/" %>
Packager: <%= maintainer %>
<% if !attributes[:no_depends] -%>

This comment has been minimized.

@jordansissel

jordansissel Nov 15, 2012

Owner

shouldn't this be :no_depends? like the deb.erb patch?

This comment has been minimized.

@dnbert

dnbert Nov 15, 2012

Contributor

Yes you are correct, I've updated that line to use the appropriate attribute.

jordansissel added a commit that referenced this pull request Nov 15, 2012

Merge pull request #289 from dnbert/master
Adding feature: --no-depends flag for deb and rpm

@jordansissel jordansissel merged commit 02e0868 into jordansissel:master Nov 15, 2012

1 check passed

default The Travis build passed
Details

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request jordansissel#289 from dnbert/master
Adding feature: --no-depends flag for deb and rpm

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request jordansissel#289 from dnbert/master
Adding feature: --no-depends flag for deb and rpm

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #289 from dnbert/master
Adding feature: --no-depends flag for deb and rpm

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #289 from dnbert/master
Adding feature: --no-depends flag for deb and rpm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment