New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #291 don't trim gem version. #292

Merged
merged 1 commit into from Nov 27, 2012

Conversation

Projects
None yet
2 participants
@r4um
Contributor

r4um commented Nov 26, 2012

Avoid trimming gem version when there are greater than 3 version sequences.

@r4um r4um referenced this pull request Nov 26, 2012

Closed

Gem version is trimmed #291

@@ -111,8 +111,8 @@ def load_package_info(gem_path)
# expand spec's version to match RationalVersioningPolicy to prevent cases
# where missing 'build' number prevents correct dependency resolution by target
# package manager. Ie. for dpkg 1.1 != 1.1.0
m = spec.version.to_s.match /^(\d)?.?(\d+)?.?(\d+)?/
self.version = m.captures.map {|m| m ? m : 0}.join('.')
m = spec.version.to_s.scan(/(\d)\.?/)

This comment has been minimized.

@jordansissel

jordansissel Nov 27, 2012

Owner

i think the \d should be \d+ here

This comment has been minimized.

@jordansissel

jordansissel Nov 27, 2012

Owner

I'll fix that prior to release.

This comment has been minimized.

@r4um

r4um Nov 27, 2012

Contributor

ah! yes. Thanks for taking care of it.

jordansissel added a commit that referenced this pull request Nov 27, 2012

Merge pull request #292 from r4um/fix_291
Fix #291 don't trim gem version.

@jordansissel jordansissel merged commit 9ba788d into jordansissel:master Nov 27, 2012

1 check passed

default The Travis build passed
Details

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #292 from r4um/fix_291
Fix #291 don't trim gem version.

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #292 from r4um/fix_291
Fix #291 don't trim gem version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment