Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a hackish (suggestion) fix to fpm #383

Closed
wants to merge 1 commit into from

Conversation

@ericbmerritt
Copy link

ericbmerritt commented Mar 16, 2013

fpm is broken when you pass --rpm-rpmbuild-define to the rpm creator. This patch may or may not be accepted. I hope it, at least, encourages someone that is better at ruby then I to come up with a smarter fix. I really would like this to get into mainstream fpm so I no longer have to roll my own.

@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Mar 20, 2013

I'm not sure what this is supposed to fix; as far as I can tell from the code, the behavior before and after this patch would be the same.

Can you explain what is not working? Do you have a sample command-line that behaves incorrectly?

@ericbmerritt

This comment has been minimized.

Copy link
Author

ericbmerritt commented Mar 21, 2013

This is a fix for the problem defined here -> https://groups.google.com/forum/?fromgroups=#!topic/fpm-users/7XGxZ_EPUOE. I get the exact same problem as the original poster and this allowed me to get past that problem.

@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Mar 21, 2013

ahh excellent, thanks for clarifying. I think I know the fix now.

jordansissel added a commit that referenced this pull request Mar 21, 2013
@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Mar 21, 2013

Closing with a fix committed. Thank you for this patch! 465ff09 implements this change without global variables but otherwise should work I think.

@ericbmerritt

This comment has been minimized.

Copy link
Author

ericbmerritt commented Mar 21, 2013

Sweet. I will pull it down and give it a shot.

@jordansissel

This comment has been minimized.

Copy link
Owner

jordansissel commented Mar 21, 2013

will work on getting a new fpm release out tonight or tomorrow

@ericbmerritt

This comment has been minimized.

Copy link
Author

ericbmerritt commented Mar 21, 2013

this seems to be resolved in 465ff09

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014
prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.