Close #378, #233 Use gem command to download gem and spec. #389

Merged
merged 5 commits into from Mar 22, 2013

Conversation

Projects
None yet
2 participants
@r4um
Collaborator

r4um commented Mar 22, 2013

  • Closes #378, #233 Use gem command to download gem and spec.
  • Uses the gem external command download gem file and gem spec.
  • Allow downloading prerelease versions via --gem-prerelease flag.
@jordansissel

This comment has been minimized.

Show comment Hide comment
@jordansissel

jordansissel Mar 22, 2013

Owner

doesnt' merge, can you fix? Otherwise I can try to merge by hand.

Owner

jordansissel commented Mar 22, 2013

doesnt' merge, can you fix? Otherwise I can try to merge by hand.

@jordansissel

View changes

lib/fpm/package/gem.rb
+
+ ::Dir.chdir(gem_cache_dir) do |dir|
+ @logger.debug("Downloading in directory #{dir}")
+ gem_fetch_stdout = %x{#{gem_fetch.join(' ')}}

This comment has been minimized.

Show comment Hide comment
@jordansissel

jordansissel Mar 22, 2013

Owner

would prefer -

  • assume teh cache dir is empty (it should be)
  • safesystem(*gem_fetch)
  • scan the cache dir for a gem file (should just see 1)

This helps avoid any whimsy that upstream rubygems does to change the way the 'gem' command outputs things.

@jordansissel

jordansissel Mar 22, 2013

Owner

would prefer -

  • assume teh cache dir is empty (it should be)
  • safesystem(*gem_fetch)
  • scan the cache dir for a gem file (should just see 1)

This helps avoid any whimsy that upstream rubygems does to change the way the 'gem' command outputs things.

This comment has been minimized.

Show comment Hide comment
@jordansissel

jordansissel Mar 22, 2013

Owner

Or in general, download it to a temporary place in the build_path (instead of gem_dir/cache) - that way you have a directory with one file.

The python package does this as well: https://github.com/jordansissel/fpm/blob/master/lib/fpm/package/python.rb#L128-L134

@jordansissel

jordansissel Mar 22, 2013

Owner

Or in general, download it to a temporary place in the build_path (instead of gem_dir/cache) - that way you have a directory with one file.

The python package does this as well: https://github.com/jordansissel/fpm/blob/master/lib/fpm/package/python.rb#L128-L134

@r4um

This comment has been minimized.

Show comment Hide comment
@r4um

r4um Mar 22, 2013

Collaborator

All tests and basic runs pass with ruby-2.0.0-p0, rubygems 2.0.3.

Collaborator

r4um commented Mar 22, 2013

All tests and basic runs pass with ruby-2.0.0-p0, rubygems 2.0.3.

jordansissel added a commit that referenced this pull request Mar 22, 2013

Merge pull request #389 from r4um/use_gem_cmd
Close #378, #233 Use gem command to download gem and spec.

@jordansissel jordansissel merged commit d8e43ff into jordansissel:master Mar 22, 2013

1 check was pending

default The Travis build is in progress
Details

@r4um r4um deleted the r4um:use_gem_cmd branch Mar 23, 2013

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 18, 2014

jls
Merge pull request #389 from r4um/use_gem_cmd
Close #378, #233 Use gem command to download gem and spec.

prof-milki pushed a commit to prof-milki/xpm that referenced this pull request Dec 27, 2014

Merge pull request #389 from r4um/use_gem_cmd
Close #378, #233 Use gem command to download gem and spec.

jordansissel added a commit that referenced this pull request Apr 24, 2015

Merge pull request #389 from r4um/use_gem_cmd
Close #378, #233 Use gem command to download gem and spec.

jordansissel added a commit that referenced this pull request Jun 20, 2016

Merge pull request #389 from r4um/use_gem_cmd
Close #378, #233 Use gem command to download gem and spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment